Skip to content

Error does not result in non-zero exit code #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kumavis opened this issue May 28, 2020 · 2 comments
Open

Error does not result in non-zero exit code #239

kumavis opened this issue May 28, 2020 · 2 comments

Comments

@kumavis
Copy link

kumavis commented May 28, 2020 

$ ./node_modules/patch-package/index.js     
patch-package 6.2.2
Applying patches...
[email protected] ✔
ethereumjs-abi/[email protected] ✔
ethereumjs-tx/[email protected] ✔
[email protected] ✔
[email protected] ✔
Error: Patch file found for package keccak which is not present at node_modules/web3-provider-engine/node_modules/keccak

results in exit code zero

this should report a non-zero exit code

related #210
@kumavis
Copy link
Author

kumavis commented May 28, 2020

looks like it is intentional #86
workaround is NODE_ENV=test

@Gudahtt Gudahtt mentioned this issue Feb 17, 2021
Open
@milahu milahu mentioned this issue Apr 14, 2022
Open
@codepainters
Copy link

Unbelievable, that ignoring an error is actually intended - I've just struggled with strange errors in a project, because I wasn't aware of a patch not being applied.

If yarn leaves the working directory in an inconsistent state after postinstall script failure, it's yarn's issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codepainters @kumavis