Remove bad assert

[Forgind]

File.Exists just returns false if its input is null, and asserting that it shouldn't be null means that if dotnet.config isn't found (which should be very common), anyone using debug bits will be unable to run any dotnet command. (Commands are all initialized before any commands are executed.)

This just removes the unnecessary assert added in #48846.

[Copilot]

Pull Request Overview

This PR removes an unnecessary Debug.Assert that could lead to issues when the dotnet.config file is missing.

• Removed assertion on dotnetConfigPath being non-null to allow File.Exists to handle null inputs.

[joeloff]

Random question, why is this under the CLI and not under the test folder?

[Forgind]

Random question, why is this under the CLI and not under the test folder?

Well, for the precise answer, we'd have to ask the bot. I'd say it kinda fits under either? It's the CLI for the test command...

[baronfel]

good point - we should push this kind of discovery into the command execution not command definition.

[Forgind]

good point - we should push this kind of discovery into the command execution not command definition.

From an architectural perspective, I think you're right. It'd be more logical as well as more performant for anyone not making running dotnet test. I tried to make the smallest change that would accomplish my goal, but I can make an issue to move it there.

[joeloff]

Random question, why is this under the CLI and not under the test folder?

Well, for the precise answer, we'd have to ask the bot. I'd say it kinda fits under either? It's the CLI for the test command...

sorry, blanked for a moment, I was confusing this with tests for CLI commands, not the dotnet test command

[nagilson]

Yes, thank you so much, this was confusing me today 👏