.NET SDK Finalizer Feature Band calculation doesn't match SDK's calculation

[dsplaisted]

In the SDK, when calculating the feature band, we look for whether several strings (including rtm) are contained in the prerelease string:

sdk/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkFeatureBand.cs

Line 17 in 861b216

if (string.IsNullOrEmpty(version.Prerelease) || version.Prerelease.Contains("dev") || version.Prerelease.Contains("ci") || version.Prerelease.Contains("rtm"))

In the finalizer, it looks like we are checking to see that one of the prerelease segments matches the list of strings, and we aren't including rtm in the list.

sdk/src/Installer/finalizer/finalizer.cpp

Lines 361 to 362 in 861b216

	if ((CSTR_EQUAL != ::CompareStringW(LOCALE_INVARIANT, 0, rgsczPrereleaseParts[0], -1, L"dev", -1)) &&
	(CSTR_EQUAL != ::CompareStringW(LOCALE_INVARIANT, 0, rgsczPrereleaseParts[0], -1, L"ci", -1)))

This means that the feature bands for versions like the following won't be calculated correctly in the finalizer:

• 9.0.100-servicing.12345.6
• 9.0.100-rtm.12345.6

This means that for SDKs with these non-stabilized version numbers, we won't correctly uninstall workload sets in the finalizer when the .NET SDK is uninstalled.

[kasperk81]

finalizer can be reimplemented as a standard C# project using https://www.nuget.org/packages/WixToolset.Dtf.WindowsInstaller, and published as a single file or AOT, both options support win x86, x64, and arm64. there's no need for cmake overhead given today's .net sdk capabilities