Nonfunctional code

Author: Forgind

src/Cli/dotnet/IDeprecated.cs

@@ -0,0 +1,26 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System.CommandLine;
+using Microsoft.DotNet.Cli.Utils;
+namespace Microsoft.DotNet.Cli;
+
+public interface IDeprecated
+{
+    public static Dictionary<CliOption, (string messageToShow, Version errorLevel)> DeprecatedOptions { get; } = new()
+    {
+        { PackageListCommandParser.DeprecatedOption, ("old versions are old", new Version(10, 0, 100)) }
+    };
+
+    public static Dictionary<CliArgument, (string messageToShow, Version errorLevel)> DeprecatedArguments { get; } = new()
+    {
+        { PackageAddCommandParser.CmdPackageArgument, ("argument bad; use option", new Version(10, 0, 100)) }
+    };
+
+    public bool IsDeprecated { get; set; }
+
+    public static void WarnIfNecessary(IReporter reporter, string messageToShow, Version errorLevel)
+    {
+        reporter.WriteLine(messageToShow);
+    }
+}

src/Cli/dotnet/Program.cs

@@ -134,6 +134,8 @@ internal static int ProcessArgs(string[] args, TimeSpan startupTime, ITelemetry
         }
         PerformanceLogEventSource.Log.BuiltInCommandParserStop();
 
+        DeprecatedCheck(parseResult);
+
         using (IFirstTimeUseNoticeSentinel disposableFirstTimeUseNoticeSentinel =
             new FirstTimeUseNoticeSentinel())
         {
@@ -306,6 +308,39 @@ private static int AdjustExitCode(ParseResult parseResult, int exitCode)
         return exitCode;
     }
 
+    private static void DeprecatedCheck(ParseResult parseResult)
+    {
+        if (parseResult.Errors.Any())
+        {
+            // There are errors anyway; don't worry about deprecation
+            return;
+        }
+
+        var command = parseResult.CommandResult;
+        if (command.Command is IDeprecated)
+        {
+            // Doesn't work because what we want is for the Command's Action's output to be deprecated (or not)
+            // And what about parents?
+        }
+
+        foreach (var entry in IDeprecated.DeprecatedArguments)
+        {
+            if (parseResult.GetArguments().Any(a => entry.Key.Name.Equals(a)))
+            {
+                // Doesn't work because this is the value, not the key, of the argument
+            }
+        }
+
+        foreach (var entry in IDeprecated.DeprecatedOptions)
+        {
+            if (parseResult.HasOption(entry.Key))
+            {
+                // Finally works!
+                IDeprecated.WarnIfNecessary(Reporter.ConsoleOutReporter, entry.Value.messageToShow, entry.Value.errorLevel);
+            }
+        }
+    }
+
     private static void ReportDotnetHomeUsage(IEnvironmentProvider provider)
     {
         var home = provider.GetEnvironmentVariable(CliFolderPathCalculator.DotnetHomeVariableName);

src/Cli/dotnet/commands/dotnet-package/remove/Program.cs

@@ -9,10 +9,11 @@
 
 namespace Microsoft.DotNet.Tools.Package.Remove;
 
-internal class RemovePackageReferenceCommand : CommandBase
+internal class RemovePackageReferenceCommand : CommandBase, IDeprecated
 {
     private readonly string _fileOrDirectory;
     private readonly IReadOnlyCollection<string> _arguments;
+    public bool IsDeprecated { get; set; } = false;
 
     public RemovePackageReferenceCommand(
         ParseResult parseResult) : base(parseResult)

src/Cli/dotnet/commands/dotnet-remove/dotnet-remove-package/RemovePackageParser.cs

@@ -23,7 +23,7 @@ private static CliCommand ConstructCommand()
         command.Arguments.Add(PackageRemoveCommandParser.CmdPackageArgument);
         command.Options.Add(PackageRemoveCommandParser.InteractiveOption);
 
-        command.SetAction((parseResult) => new RemovePackageReferenceCommand(parseResult).Execute());
+        command.SetAction((parseResult) => new RemovePackageReferenceCommand(parseResult) { IsDeprecated = true }.Execute());
 
         return command;
     }