Skip to content

Commit 75d7493

Browse files
committed
Fixup sourcelink information
Most repos are setting the RepositoryUrl directly in their directory.build.props. This leads to incorrect sourcelink information. The SHA built does not exist in the isolated repo.
1 parent b1d1a0d commit 75d7493

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/SourceBuild/content/repo-projects/Directory.Build.props

+3
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@
7575
still use the OfficialBuildId from repositories, not the pipeline. -->
7676
<PropertyGroup Condition="'$(OfficialBuildId)' != '' and '$(DotNetBuildSourceOnly)' != 'true'">
7777
<OfficialBuildId>$(OfficialBuildId.Split('.')[0]).$([MSBuild]::Add($(OfficialBuildId.Split('.')[1]), 100))</OfficialBuildId>
78+
<DotNetRepositoryUrl>https://github.com/dotnet/dotnet</DotNetRepositoryUrl>
7879
</PropertyGroup>
7980

8081
<PropertyGroup>
@@ -125,6 +126,8 @@
125126
<!-- Don't flow these control properties during testing to avoid the outer/inner complexity. -->
126127
<BuildArgs>$(BuildArgs) /p:DotNetBuildRepo=true</BuildArgs>
127128
<BuildArgs>$(BuildArgs) /p:DotNetBuildOrchestrator=true</BuildArgs>
129+
<!-- Pass the repository URL in globally so that we redirect sourcelink package information to the VMR repo. -->
130+
<BuildArgs>$(BuildArgs) /p:RepositoryUrl=$(DotNetRepositoryUrl)</BuildArgs>
128131
</PropertyGroup>
129132
<PropertyGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'">
130133
<BuildArgs>$(BuildArgs) /p:SourceBuiltSymbolsDir=$(IntermediateSymbolsRepoDir)</BuildArgs>

0 commit comments

Comments
 (0)