Skip to content

Commit f2a1313

Browse files
authored
Re-enable skiasharp WBT tests (#109232) (#110734)
* [wasm] Re-enable skiasharp WBT tests * Disable Debug/AOT combination That would trigger build error, because we don't support that combination anymore
1 parent e781fb7 commit f2a1313

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

src/mono/wasm/Wasm.Build.Tests/Blazor/MiscTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ public MiscTests(ITestOutputHelper output, SharedBuildPerTestClassFixture buildC
2222
[InlineData("Debug", false)]
2323
[InlineData("Release", true)]
2424
[InlineData("Release", false)]
25-
[ActiveIssue("https://github.com/dotnet/runtime/issues/103566")]
2625
public void NativeBuild_WithDeployOnBuild_UsedByVS(string config, bool nativeRelink)
2726
{
2827
string id = $"blz_deploy_on_build_{config}_{nativeRelink}_{GetRandomId()}";

src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,8 +605,8 @@ internal BuildPaths GetBuildPaths(BuildArgs buildArgs, bool forPublish = true)
605605
}
606606

607607
protected static string GetSkiaSharpReferenceItems()
608-
=> @"<PackageReference Include=""SkiaSharp"" Version=""2.88.6"" />
609-
<PackageReference Include=""SkiaSharp.NativeAssets.WebAssembly"" Version=""2.88.6"" />
608+
=> @"<PackageReference Include=""SkiaSharp"" Version=""2.88.9-preview.2.2"" />
609+
<PackageReference Include=""SkiaSharp.NativeAssets.WebAssembly"" Version=""2.88.9-preview.2.2"" />
610610
<NativeFileReference Include=""$(SkiaSharpStaticLibraryPath)\3.1.56\st\*.a"" />";
611611

612612
protected static string s_mainReturns42 = @"

src/mono/wasm/Wasm.Build.Tests/NativeLibraryTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ public void ProjectWithNativeReference(BuildArgs buildArgs, RunHost host, string
5050

5151
[Theory]
5252
[BuildAndRun(aot: false)]
53-
[BuildAndRun(aot: true)]
54-
[ActiveIssue("https://github.com/dotnet/runtime/issues/103566")]
53+
[BuildAndRun(aot: true, config: "Release")]
5554
public void ProjectUsingSkiaSharp(BuildArgs buildArgs, RunHost host, string id)
5655
{
5756
string projectName = $"AppUsingSkiaSharp";

0 commit comments

Comments
 (0)