Skip to content

Commit ca710ec

Browse files
authored
Reapply "[browser][MT] move wasm MT CI legs to extra-platforms (#112712)" (#112716)
* Revert "Revert "[browser][MT] move wasm MT CI legs to extra-platforms (#11269…" This reverts commit d6b6298. * Only include multithreaded job dependency when we have it * Fixup * Keep MT build for WBT * Remove WASI from runtime.yml too, keep it only in extra-platforms * Keep build-only WBT in runtime.yml
1 parent 2d73b37 commit ca710ec

File tree

3 files changed

+17
-28
lines changed

3 files changed

+17
-28
lines changed

eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml

+16-1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,22 @@ jobs:
7474
scenarios:
7575
- WasmTestOnChrome
7676

77+
# Library tests with full threading
78+
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
79+
parameters:
80+
platforms:
81+
- browser_wasm
82+
#- browser_wasm_win
83+
nameSuffix: _Threading
84+
extraBuildArgs: /p:WasmEnableThreads=true /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
85+
extraHelixArguments: /p:WasmEnableThreads=true
86+
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
87+
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
88+
alwaysRun: ${{ parameters.isWasmOnlyBuild }}
89+
shouldRunSmokeOnly: onLibrariesAndIllinkChanges
90+
scenarios:
91+
- WasmTestOnChrome
92+
7793
# EAT Library tests - only run on linux
7894
- template: /eng/pipelines/common/templates/wasm-library-aot-tests.yml
7995
parameters:
@@ -162,7 +178,6 @@ jobs:
162178
- browser_wasm_win
163179
nameSuffix: MultiThreaded
164180
extraBuildArgs: /p:WasmEnableThreads=true /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
165-
condition: ne(variables['wasmMultiThreadedBuildOnlyNeededOnDefaultPipeline'], true)
166181
publishArtifactsForWorkload: true
167182
publishWBT: false
168183

eng/pipelines/runtime.yml

-26
Original file line numberDiff line numberDiff line change
@@ -822,20 +822,6 @@ extends:
822822
scenarios:
823823
- WasmTestOnChrome
824824

825-
# Library tests with full threading
826-
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
827-
parameters:
828-
platforms:
829-
- browser_wasm
830-
#- browser_wasm_win
831-
nameSuffix: _Threading
832-
extraBuildArgs: /p:WasmEnableThreads=true /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
833-
extraHelixArguments: /p:WasmEnableThreads=true
834-
alwaysRun: ${{ variables.isRollingBuild }}
835-
shouldRunSmokeOnly: onLibrariesAndIllinkChanges
836-
scenarios:
837-
- WasmTestOnChrome
838-
839825
# EAT Library tests - only run on linux
840826
- template: /eng/pipelines/common/templates/wasm-library-aot-tests.yml
841827
parameters:
@@ -901,18 +887,6 @@ extends:
901887

902888
# WASI/WASM
903889

904-
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
905-
parameters:
906-
platforms:
907-
- wasi_wasm
908-
- wasi_wasm_win
909-
nameSuffix: '_Smoke'
910-
extraBuildArgs: /p:EnableAggressiveTrimming=true /p:RunWasmSamples=true /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
911-
shouldRunSmokeOnly: true
912-
alwaysRun: ${{ variables.isRollingBuild }}
913-
scenarios:
914-
- WasmTestOnWasmtime
915-
916890
- template: /eng/pipelines/common/templates/simple-wasm-build-tests.yml
917891
parameters:
918892
platforms:

src/mono/wasm/features.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Some of these properties require a unique build of the runtime, which means that
2323

2424
### Multi-threading
2525

26-
Multi-threading support is enabled by `<WasmEnableThreads>true</WasmEnableThreads>`, and is currently disabled by default. It requires a unique build of the runtime.
26+
Multi-threading experiment is enabled by `<WasmEnableThreads>true</WasmEnableThreads>`, and is currently disabled by default. It requires a unique build of the runtime.
2727

2828
Your HTTPS server and/or proxy must be configured to send HTTP headers similar to `Cross-Origin-Embedder-Policy:require-corp` and `Cross-Origin-Opener-Policy:same-origin` in order to enable multi-threading support in end-user web browsers for security reasons.
2929

0 commit comments

Comments
 (0)