Replace a few SuppressMessage annotations with UnconditionalSuppressMessage (#109186)

github-actions[bot] · eiriktsarpalis · web-flow · commit 450644122f64 · 2025-01-13T13:45:01.000-06:00
Co-authored-by: Eirik Tsarpalis &lt;eirik.tsarpalis@gmail.com&gt;
diff --git a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverterFactory.cs b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverterFactory.cs
@@ -25,7 +25,7 @@ public static bool IsSupportedTypeCode(TypeCode typeCode)
                             or TypeCode.Byte or TypeCode.UInt16 or TypeCode.UInt32 or TypeCode.UInt64;
         }
 
-        [SuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.",
+        [UnconditionalSuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.",
             Justification = "The constructor has been annotated with RequiredDynamicCodeAttribute.")]
         public override JsonConverter CreateConverter(Type type, JsonSerializerOptions options)
         {
diff --git a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionEmitMemberAccessor.cs b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionEmitMemberAccessor.cs
@@ -18,7 +18,7 @@ public ReflectionEmitMemberAccessor()
         {
         }
 
-        [SuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.",
+        [UnconditionalSuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.",
             Justification = "The constructor has been marked RequiresDynamicCode")]
         public override Func<object>? CreateParameterlessConstructor(Type type, ConstructorInfo? constructorInfo)
         {

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public static bool IsSupportedTypeCode(TypeCode typeCode)`
`25`	`25`	`or TypeCode.Byte or TypeCode.UInt16 or TypeCode.UInt32 or TypeCode.UInt64;`
`26`	`26`	`}`
`27`	`27`
`28`		`- [SuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.",`
	`28`	`+ [UnconditionalSuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.",`
`29`	`29`	`Justification = "The constructor has been annotated with RequiredDynamicCodeAttribute.")]`
`30`	`30`	`public override JsonConverter CreateConverter(Type type, JsonSerializerOptions options)`
`31`	`31`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public ReflectionEmitMemberAccessor()`
`18`	`18`	`{`
`19`	`19`	`}`
`20`	`20`
`21`		`- [SuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.",`
	`21`	`+ [UnconditionalSuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.",`
`22`	`22`	`Justification = "The constructor has been marked RequiresDynamicCode")]`
`23`	`23`	`public override Func<object>? CreateParameterlessConstructor(Type type, ConstructorInfo? constructorInfo)`
`24`	`24`	`{`