Use LangVersion 8 in tests rather than Preview (#39421)

jcouv · web-flow · commit fef3d37a9ce3 · 2019-10-21T15:24:01.000-07:00
diff --git a/src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenAsyncIteratorTests.cs b/src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenAsyncIteratorTests.cs
@@ -267,7 +267,7 @@ static async System.Collections.Generic.IAsyncEnumerable<int> M()
             var comp = CreateCompilationWithTasksExtensions(new[] { source }, parseOptions: TestOptions.Regular7_3);
             comp.VerifyDiagnostics(expected);
 
-            comp = CreateCompilationWithTasksExtensions(new[] { source }, parseOptions: TestOptions.RegularPreview);
+            comp = CreateCompilationWithTasksExtensions(new[] { source }, parseOptions: TestOptions.Regular8);
             comp.VerifyDiagnostics(
                 // (4,45): error CS0234: The type or namespace name 'IAsyncEnumerable<>' does not exist in the namespace 'System.Collections.Generic' (are you missing an assembly reference?)
                 //     static async System.Collections.Generic.IAsyncEnumerable<int> M()
@@ -1290,7 +1290,7 @@ async System.Collections.Generic.IAsyncEnumerator<int> M()
             var comp = CreateCompilationWithTasksExtensions(new[] { source, AsyncStreamsTypes }, parseOptions: TestOptions.Regular7_3);
             comp.VerifyDiagnostics(expected);
 
-            comp = CreateCompilationWithTasksExtensions(new[] { source, AsyncStreamsTypes }, parseOptions: TestOptions.RegularPreview);
+            comp = CreateCompilationWithTasksExtensions(new[] { source, AsyncStreamsTypes }, parseOptions: TestOptions.Regular8);
             comp.VerifyDiagnostics();
         }
 
diff --git a/src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenAwaitForeachTests.cs b/src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenAwaitForeachTests.cs
@@ -38,7 +38,7 @@ IAsyncEnumerator<int> IAsyncEnumerable<int>.GetAsyncEnumerator(System.Threading.
             var comp = CreateCompilationWithTasksExtensions(new[] { source, s_IAsyncEnumerable }, parseOptions: TestOptions.Regular7_3);
             comp.VerifyDiagnostics(expected);
 
-            comp = CreateCompilationWithTasksExtensions(new[] { source, s_IAsyncEnumerable }, parseOptions: TestOptions.RegularPreview);
+            comp = CreateCompilationWithTasksExtensions(new[] { source, s_IAsyncEnumerable }, parseOptions: TestOptions.Regular8);
             comp.VerifyDiagnostics();
         }
 
diff --git a/src/Compilers/CSharp/Test/Semantic/Semantics/IndexAndRangeTests.cs b/src/Compilers/CSharp/Test/Semantic/Semantics/IndexAndRangeTests.cs
@@ -991,7 +991,7 @@ void M()
     }
 }";
             var compilation = CreateCompilationWithIndex(source, parseOptions: TestOptions.Regular7_3).VerifyDiagnostics(expected);
-            compilation = CreateCompilationWithIndex(source, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics();
+            compilation = CreateCompilationWithIndex(source, parseOptions: TestOptions.Regular8).VerifyDiagnostics();
         }
 
         [Fact]
@@ -1474,7 +1474,7 @@ void M()
                 Diagnostic(ErrorCode.ERR_FeatureNotAvailableInVersion7_3, "..").WithArguments("range operator", "8.0").WithLocation(9, 17)
             };
             CreateCompilationWithIndexAndRange(source, parseOptions: TestOptions.Regular7_3).VerifyDiagnostics(expected);
-            CreateCompilationWithIndexAndRange(source, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics();
+            CreateCompilationWithIndexAndRange(source, parseOptions: TestOptions.Regular8).VerifyDiagnostics();
         }
 
         [Fact]
diff --git a/src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs b/src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
@@ -7598,7 +7598,7 @@ void M(string z)
             var c = CreateCompilation(new[] { source });
             c.VerifyDiagnostics(expected);
 
-            c = CreateCompilation(source, parseOptions: TestOptions.RegularPreview);
+            c = CreateCompilation(source, parseOptions: TestOptions.Regular8);
             c.VerifyDiagnostics(expected);
 
             expected = new[]
diff --git a/src/Compilers/CSharp/Test/Semantic/Semantics/NullableTests.cs b/src/Compilers/CSharp/Test/Semantic/Semantics/NullableTests.cs
@@ -65,7 +65,7 @@ static void Main()
             };
             var comp = CreateCompilation(source, parseOptions: TestOptions.Regular7_3);
             comp.VerifyDiagnostics(expected);
-            comp = CreateCompilation(source, parseOptions: TestOptions.RegularPreview);
+            comp = CreateCompilation(source, parseOptions: TestOptions.Regular8);
             comp.VerifyDiagnostics(
                 // (7,11): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' context.
                 //     string? s1 = null;
diff --git a/src/Compilers/CSharp/Test/Semantic/Semantics/PatternMatchingTests2.cs b/src/Compilers/CSharp/Test/Semantic/Semantics/PatternMatchingTests2.cs
@@ -384,7 +384,7 @@ public static void Main()
                 Diagnostic(ErrorCode.ERR_FeatureNotAvailableInVersion7_3, "1 switch { _ => 0, }").WithArguments("recursive patterns", "8.0").WithLocation(5, 17)
                 );
 
-            CreateCompilation(source, options: TestOptions.DebugExe, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics();
+            CreateCompilation(source, options: TestOptions.DebugExe, parseOptions: TestOptions.Regular8).VerifyDiagnostics();
         }
 
         [Fact]
@@ -1093,7 +1093,7 @@ class _ {}
             var compilation = CreatePatternCompilation(source);
             compilation.VerifyDiagnostics(expected);
 
-            compilation = CreateCompilation(source, parseOptions: TestOptions.RegularPreview);
+            compilation = CreateCompilation(source, parseOptions: TestOptions.Regular8);
             compilation.VerifyDiagnostics(expected);
 
             expected = new[]
diff --git a/src/Compilers/CSharp/Test/Semantic/Semantics/UsingDeclarationTests.cs b/src/Compilers/CSharp/Test/Semantic/Semantics/UsingDeclarationTests.cs
@@ -670,7 +670,7 @@ static void Main()
 
             CreateCompilation(source, parseOptions: TestOptions.Regular7_3).VerifyDiagnostics(expected);
 
-            CreateCompilation(source, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics();
+            CreateCompilation(source, parseOptions: TestOptions.Regular8).VerifyDiagnostics();
         }
 
         [Fact]
@@ -696,7 +696,7 @@ static async Task Main()
 
             CreateCompilationWithTasksExtensions(new[] { source, IAsyncDisposableDefinition }, parseOptions: TestOptions.Regular7_3).VerifyDiagnostics(expected);
 
-            CreateCompilationWithTasksExtensions(new[] { source, IAsyncDisposableDefinition }, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics();
+            CreateCompilationWithTasksExtensions(new[] { source, IAsyncDisposableDefinition }, parseOptions: TestOptions.Regular8).VerifyDiagnostics();
         }
 
         [Fact]
@@ -772,7 +772,7 @@ static void Main()
     }
 }
 ";
-            CreateCompilation(source, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics(
+            CreateCompilation(source, parseOptions: TestOptions.Regular8).VerifyDiagnostics(
                 // (7,15): error CS0106: The modifier 'public' is not valid for this item
                 //         using public readonly var x = (IDisposable)null;
                 Diagnostic(ErrorCode.ERR_BadMemberFlag, "public").WithArguments("public").WithLocation(7, 15),
diff --git a/src/Compilers/CSharp/Test/Syntax/Parsing/PatternParsingTests.cs b/src/Compilers/CSharp/Test/Syntax/Parsing/PatternParsingTests.cs
@@ -1847,7 +1847,7 @@ public void ParenthesizedExpression_03()
             UsingStatement(@"switch (e) { case (x: ((3))): ; }", TestOptions.RegularWithoutRecursivePatterns, expect);
             checkNodes();
 
-            UsingStatement(@"switch (e) { case (x: ((3))): ; }", TestOptions.RegularPreview);
+            UsingStatement(@"switch (e) { case (x: ((3))): ; }", TestOptions.Regular8);
             checkNodes();
 
             void checkNodes()

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ IAsyncEnumerator<int> IAsyncEnumerable<int>.GetAsyncEnumerator(System.Threading.`
`38`	`38`	`var comp = CreateCompilationWithTasksExtensions(new[] { source, s_IAsyncEnumerable }, parseOptions: TestOptions.Regular7_3);`
`39`	`39`	`comp.VerifyDiagnostics(expected);`
`40`	`40`
`41`		`- comp = CreateCompilationWithTasksExtensions(new[] { source, s_IAsyncEnumerable }, parseOptions: TestOptions.RegularPreview);`
	`41`	`+ comp = CreateCompilationWithTasksExtensions(new[] { source, s_IAsyncEnumerable }, parseOptions: TestOptions.Regular8);`
`42`	`42`	`comp.VerifyDiagnostics();`
`43`	`43`	`}`
`44`	`44`
Original file line number	Diff line number	Diff line change
`@@ -991,7 +991,7 @@ void M()`
`991`	`991`	`}`
`992`	`992`	`}";`
`993`	`993`	`var compilation = CreateCompilationWithIndex(source, parseOptions: TestOptions.Regular7_3).VerifyDiagnostics(expected);`
`994`		`- compilation = CreateCompilationWithIndex(source, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics();`
	`994`	`+ compilation = CreateCompilationWithIndex(source, parseOptions: TestOptions.Regular8).VerifyDiagnostics();`
`995`	`995`	`}`
`996`	`996`
`997`	`997`	`[Fact]`
`@@ -1474,7 +1474,7 @@ void M()`
`1474`	`1474`	`Diagnostic(ErrorCode.ERR_FeatureNotAvailableInVersion7_3, "..").WithArguments("range operator", "8.0").WithLocation(9, 17)`
`1475`	`1475`	`};`
`1476`	`1476`	`CreateCompilationWithIndexAndRange(source, parseOptions: TestOptions.Regular7_3).VerifyDiagnostics(expected);`
`1477`		`- CreateCompilationWithIndexAndRange(source, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics();`
	`1477`	`+ CreateCompilationWithIndexAndRange(source, parseOptions: TestOptions.Regular8).VerifyDiagnostics();`
`1478`	`1478`	`}`
`1479`	`1479`
`1480`	`1480`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -670,7 +670,7 @@ static void Main()`
`670`	`670`
`671`	`671`	`CreateCompilation(source, parseOptions: TestOptions.Regular7_3).VerifyDiagnostics(expected);`
`672`	`672`
`673`		`- CreateCompilation(source, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics();`
	`673`	`+ CreateCompilation(source, parseOptions: TestOptions.Regular8).VerifyDiagnostics();`
`674`	`674`	`}`
`675`	`675`
`676`	`676`	`[Fact]`
`@@ -696,7 +696,7 @@ static async Task Main()`
`696`	`696`
`697`	`697`	`CreateCompilationWithTasksExtensions(new[] { source, IAsyncDisposableDefinition }, parseOptions: TestOptions.Regular7_3).VerifyDiagnostics(expected);`
`698`	`698`
`699`		`- CreateCompilationWithTasksExtensions(new[] { source, IAsyncDisposableDefinition }, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics();`
	`699`	`+ CreateCompilationWithTasksExtensions(new[] { source, IAsyncDisposableDefinition }, parseOptions: TestOptions.Regular8).VerifyDiagnostics();`
`700`	`700`	`}`
`701`	`701`
`702`	`702`	`[Fact]`
`@@ -772,7 +772,7 @@ static void Main()`
`772`	`772`	`}`
`773`	`773`	`}`
`774`	`774`	`";`
`775`		`- CreateCompilation(source, parseOptions: TestOptions.RegularPreview).VerifyDiagnostics(`
	`775`	`+ CreateCompilation(source, parseOptions: TestOptions.Regular8).VerifyDiagnostics(`
`776`	`776`	`// (7,15): error CS0106: The modifier 'public' is not valid for this item`
`777`	`777`	`// using public readonly var x = (IDisposable)null;`
`778`	`778`	`Diagnostic(ErrorCode.ERR_BadMemberFlag, "public").WithArguments("public").WithLocation(7, 15),`