Lint

Author: CyrusNajmabadi

src/Workspaces/Core/Portable/Workspace/IsolatedAnalyzerReferenceSet.Desktop.cs

@@ -5,13 +5,13 @@
 #if !NET
 
 using System;
-using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Host;
 using Microsoft.CodeAnalysis.Serialization;
+using Roslyn.Utilities;
 
 namespace Microsoft.CodeAnalysis;
 
@@ -27,17 +27,17 @@ public static partial ValueTask<ImmutableArray<AnalyzerReference>> CreateIsolate
         SolutionServices solutionServices,
         CancellationToken cancellationToken)
     {
-        return DefaultCreateIsolatedAnalyzerReferencesAsync(references);
+        return ValueTaskFactory.FromResult(references);
     }
 
-    public static partial ValueTask<ImmutableArray<AnalyzerReference>> CreateIsolatedAnalyzerReferencesAsync(
+    public static async partial ValueTask<ImmutableArray<AnalyzerReference>> CreateIsolatedAnalyzerReferencesAsync(
         bool useAsync,
         ChecksumCollection analyzerChecksums,
         SolutionServices solutionServices,
         Func<Task<ImmutableArray<AnalyzerReference>>> getReferencesAsync,
         CancellationToken cancellationToken)
     {
-        return DefaultCreateIsolatedAnalyzerReferencesAsync(getReferencesAsync);
+        return await getReferencesAsync().ConfigureAwait(false);
     }
 }
 

src/Workspaces/Core/Portable/Workspace/IsolatedAnalyzerReferenceSet.cs

@@ -39,18 +39,6 @@ public static partial ValueTask<ImmutableArray<AnalyzerReference>> CreateIsolate
         Func<Task<ImmutableArray<AnalyzerReference>>> getReferencesAsync,
         CancellationToken cancellationToken);
 
-    private static ValueTask<ImmutableArray<AnalyzerReference>> DefaultCreateIsolatedAnalyzerReferencesAsync(
-        ImmutableArray<AnalyzerReference> references)
-    {
-        return ValueTaskFactory.FromResult(references);
-    }
-
-    private static async ValueTask<ImmutableArray<AnalyzerReference>> DefaultCreateIsolatedAnalyzerReferencesAsync(
-        Func<Task<ImmutableArray<AnalyzerReference>>> getReferencesAsync)
-    {
-        return await getReferencesAsync().ConfigureAwait(false);
-    }
-
     public static Guid TryGetFileReferenceMvid(string filePath)
     {
         try