Use Extension as data type for Extension Message Handlers errors and remove DocumentLinePosition (#78121)

Author: CyrusNajmabadi

src/LanguageServer/Protocol/Handler/Extensions/ExtensionDocumentMessageHandler.cs

@@ -38,9 +38,6 @@ public async Task<ExtensionMessageResponse> HandleRequestAsync(ExtensionDocument
         if (exception is not null)
             context.Logger.LogException(exception);
 
-        return new ExtensionMessageResponse(
-            response,
-            extensionWasUnloaded,
-            ExtensionException.FromException(exception));
+        return new ExtensionMessageResponse(response, extensionWasUnloaded, exception);
     }
 }

src/LanguageServer/Protocol/Handler/Extensions/ExtensionException.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
 using System.Text.Json.Serialization;
 
 namespace Microsoft.CodeAnalysis.LanguageServer.Handler.Extensions;
@@ -15,5 +16,4 @@ namespace Microsoft.CodeAnalysis.LanguageServer.Handler.Extensions;
 internal readonly record struct ExtensionMessageResponse(
     [property: JsonPropertyName("response"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] string? Response,
     [property: JsonPropertyName("extensionWasUnloaded"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)] bool ExtensionWasUnloaded,
-    [property: JsonPropertyName("extensionException"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
-        ExtensionException? ExtensionException);
+    [property: JsonPropertyName("extensionException"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] Exception? ExtensionException);

src/LanguageServer/Protocol/Handler/Extensions/ExtensionMessageResponse.cs

@@ -37,6 +37,6 @@ public async Task<ExtensionRegisterResponse> HandleRequestAsync(ExtensionRegiste
         return new(
             handlerNames.WorkspaceMessageHandlers,
             handlerNames.DocumentMessageHandlers,
-            ExtensionException.FromException(handlerNames.ExtensionException));
+            handlerNames.ExtensionException);
     }
 }

src/LanguageServer/Protocol/Handler/Extensions/ExtensionRegisterHandler.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
 using System.Collections.Immutable;
 using System.Text.Json.Serialization;
 
@@ -16,5 +17,4 @@ namespace Microsoft.CodeAnalysis.LanguageServer.Handler.Extensions;
 internal sealed record class ExtensionRegisterResponse(
     [property: JsonPropertyName("workspaceMessageHandlers")] ImmutableArray<string> WorkspaceMessageHandlers,
     [property: JsonPropertyName("documentMessageHandlers")] ImmutableArray<string> DocumentMessageHandlers,
-    [property: JsonPropertyName("extensionException"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
-        ExtensionException? ExtensionException);
+    [property: JsonPropertyName("extensionException"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] Exception? ExtensionException);

src/LanguageServer/Protocol/Handler/Extensions/ExtensionRegisterResponse.cs

@@ -34,9 +34,6 @@ public async Task<ExtensionMessageResponse> HandleRequestAsync(ExtensionWorkspac
         if (exception is not null)
             context.Logger.LogException(exception);
 
-        return new ExtensionMessageResponse(
-            response,
-            extensionWasUnloaded,
-            ExtensionException.FromException(exception));
+        return new ExtensionMessageResponse(response, extensionWasUnloaded, exception);
     }
 }

src/LanguageServer/Protocol/Handler/Extensions/ExtensionWorkspaceMessageHandler.cs

@@ -1,15 +1,6 @@
-Microsoft.CodeAnalysis.Extensions.DocumentLinePosition
-Microsoft.CodeAnalysis.Extensions.DocumentLinePosition.Character.get -> int
-Microsoft.CodeAnalysis.Extensions.DocumentLinePosition.DocumentLinePosition() -> void
-Microsoft.CodeAnalysis.Extensions.DocumentLinePosition.DocumentLinePosition(Microsoft.CodeAnalysis.Document document, Microsoft.CodeAnalysis.Text.LinePosition linePosition) -> void
-Microsoft.CodeAnalysis.Extensions.DocumentLinePosition.DocumentLinePosition(string filePath, int line, int character) -> void
-Microsoft.CodeAnalysis.Extensions.DocumentLinePosition.FilePath.get -> string
-Microsoft.CodeAnalysis.Extensions.DocumentLinePosition.Line.get -> int
-Microsoft.CodeAnalysis.Extensions.DocumentLinePosition.ToLinePosition() -> Microsoft.CodeAnalysis.Text.LinePosition
 Microsoft.CodeAnalysis.Extensions.ExtensionMessageContext
 Microsoft.CodeAnalysis.Extensions.ExtensionMessageContext.Solution.get -> Microsoft.CodeAnalysis.Solution
 Microsoft.CodeAnalysis.Extensions.IExtensionDocumentMessageHandler<TMessage, TResponse>
 Microsoft.CodeAnalysis.Extensions.IExtensionDocumentMessageHandler<TMessage, TResponse>.ExecuteAsync(TMessage message, Microsoft.CodeAnalysis.Extensions.ExtensionMessageContext context, Microsoft.CodeAnalysis.Document document, System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.Task<TResponse>
 Microsoft.CodeAnalysis.Extensions.IExtensionWorkspaceMessageHandler<TMessage, TResponse>
-Microsoft.CodeAnalysis.Extensions.IExtensionWorkspaceMessageHandler<TMessage, TResponse>.ExecuteAsync(TMessage message, Microsoft.CodeAnalysis.Extensions.ExtensionMessageContext context, System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.Task<TResponse>
-static Microsoft.CodeAnalysis.Extensions.DocumentLinePosition.implicit operator Microsoft.CodeAnalysis.Text.LinePosition(Microsoft.CodeAnalysis.Extensions.DocumentLinePosition documentLinePosition) -> Microsoft.CodeAnalysis.Text.LinePosition
+Microsoft.CodeAnalysis.Extensions.IExtensionWorkspaceMessageHandler<TMessage, TResponse>.ExecuteAsync(TMessage message, Microsoft.CodeAnalysis.Extensions.ExtensionMessageContext context, System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.Task<TResponse>