Skip to content

Commit 11f86e6

Browse files
committed
Tweaks
1 parent adc0129 commit 11f86e6

File tree

3 files changed

+78
-78
lines changed

3 files changed

+78
-78
lines changed

src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,9 @@ internal BoundExpression MakeInvocationExpression(
137137
}
138138

139139
BoundExpression result = BindInvocationExpression(
140-
node, node, methodName, boundExpression, analyzedArguments, diagnostics, queryClause,
141-
ignoreNormalFormIfHasValidParamsParameter: ignoreNormalFormIfHasValidParamsParameter,
142-
disallowExpandedNonArrayParams: disallowExpandedNonArrayParams, acceptOnlyMethods: !allowFieldsAndProperties);
140+
node, node, methodName, boundExpression, analyzedArguments, diagnostics, acceptOnlyMethods: !allowFieldsAndProperties,
141+
queryClause: queryClause, ignoreNormalFormIfHasValidParamsParameter: ignoreNormalFormIfHasValidParamsParameter,
142+
disallowExpandedNonArrayParams: disallowExpandedNonArrayParams);
143143

144144
// Query operator can't be called dynamically.
145145
if (queryClause != null && result.Kind == BoundKind.DynamicInvocation)
@@ -324,10 +324,10 @@ private BoundExpression BindInvocationExpression(
324324
BoundExpression boundExpression,
325325
AnalyzedArguments analyzedArguments,
326326
BindingDiagnosticBag diagnostics,
327+
bool acceptOnlyMethods,
327328
CSharpSyntaxNode queryClause = null,
328329
bool ignoreNormalFormIfHasValidParamsParameter = false,
329-
bool disallowExpandedNonArrayParams = false,
330-
bool acceptOnlyMethods = false)
330+
bool disallowExpandedNonArrayParams = false)
331331
{
332332
//
333333
// !!! ATTENTION !!!
@@ -728,7 +728,7 @@ private BoundExpression BindMethodGroupInvocation(
728728
Debug.Assert(extensionMemberAccess.Kind != BoundKind.MethodGroup);
729729

730730
extensionMemberAccess = CheckValue(extensionMemberAccess, BindValueKind.RValue, diagnostics);
731-
BoundExpression extensionMemberInvocation = BindInvocationExpression(syntax, expression, methodName: null, extensionMemberAccess, analyzedArguments, diagnostics, acceptOnlyMethods: false);
731+
BoundExpression extensionMemberInvocation = BindInvocationExpression(syntax, expression, methodName: null, boundExpression: extensionMemberAccess, analyzedArguments: analyzedArguments, diagnostics: diagnostics, acceptOnlyMethods: false);
732732
anyApplicableCandidates = !extensionMemberInvocation.HasAnyErrors;
733733
return extensionMemberInvocation;
734734
}

src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_ObjectOrCollectionInitializerExpression.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -702,6 +702,8 @@ private BoundExpression MakeObjectInitializerMemberAccess(
702702
_compilation.Conversions.HasImplicitConversionToOrImplementsVarianceCompatibleInterface(rewrittenReceiver.Type, memberSymbol.ContainingType, ref discardedUseSiteInfo, out _));
703703
// It is possible there are use site diagnostics from the above, but none that we need report as we aren't generating code for the conversion
704704
#endif
705+
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : handle creating a conversion on receiver
706+
// TODO2
705707

706708
switch (memberSymbol.Kind)
707709
{

0 commit comments

Comments
 (0)