Merge pull request #3807 from mavasani/UpdateAnalyzerPackageAndFixCA1836

Update .NET analyzers package and fix CA1836 violations

Author: mavasani

.editorconfig

@@ -246,7 +246,3 @@ dotnet_code_quality.CA1720.api_surface = public
 # Exclude single letter type parameter names
 # CA1715: Identifiers should have correct prefix
 dotnet_code_quality.CA1715.exclude_single_letter_type_parameters = true
-
-# CA1836: Prefer IsEmpty over Count/Length
-# Can enable it as a warning once https://github.com/dotnet/roslyn-analyzers/issues/3798 is fixed to unblock FixAll
-dotnet_diagnostic.CA1836.severity = suggestion

eng/Versions.props

@@ -26,7 +26,7 @@
     <MicrosoftNetCompilersToolsetVersion>$(MicrosoftNETCoreCompilersPackageVersion)</MicrosoftNetCompilersToolsetVersion>
     <!-- Roslyn -->
     <MicrosoftCodeAnalysisVersion>2.9.0</MicrosoftCodeAnalysisVersion>
-    <DogfoodAnalyzersVersion>3.3.0-beta1.20330.1</DogfoodAnalyzersVersion>
+    <DogfoodAnalyzersVersion>3.3.0-beta1.20351.1</DogfoodAnalyzersVersion>
     <MicrosoftCodeAnalysisBannedApiAnalyzersVersion>$(DogfoodAnalyzersVersion)</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
     <MicrosoftCodeAnalysisFXCopAnalyersVersion>$(DogfoodAnalyzersVersion)</MicrosoftCodeAnalysisFXCopAnalyersVersion>
     <MicrosoftCodeAnalysisAnalyersVersion>$(DogfoodAnalyzersVersion)</MicrosoftCodeAnalysisAnalyersVersion>

src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/RegisterActionAnalyzer.cs

@@ -383,7 +383,7 @@ private void AnalyzeInvocation(SyntaxNodeAnalysisContext context)
                     }
                 }
 
-                if (method.TypeParameters.Length > 0 &&
+                if (!method.TypeParameters.IsEmpty &&
                     (isRegisterSyntaxNodeAction || isRegisterCodeBlockStartAction))
                 {
                     ITypeSymbol? typeArgument = null;

src/NetAnalyzers/CSharp/Microsoft.CodeQuality.Analyzers/QualityGuidelines/CSharpRethrowToPreserveStackDetails.cs

@@ -39,7 +39,7 @@ private static void AnalyzeNode(SyntaxNodeAnalysisContext context)
                                 catchClause.Declaration.Identifier.RawKind != 0)
                             {
                                 if (!(context.SemanticModel.GetSymbolInfo(expr).Symbol is ILocalSymbol local)
-                                    || local.Locations.Length == 0
+                                    || local.Locations.IsEmpty
                                     || context.SemanticModel.AnalyzeDataFlow(catchClause.Block).WrittenInside.Contains(local))
                                 {
                                     return;

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/AbstractTypesShouldNotHaveConstructors.Fixer.cs

@@ -37,7 +37,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
 
         private static SyntaxNode? GetDeclaration(ISymbol symbol)
         {
-            return (symbol.DeclaringSyntaxReferences.Length > 0) ? symbol.DeclaringSyntaxReferences[0].GetSyntax() : null;
+            return (!symbol.DeclaringSyntaxReferences.IsEmpty) ? symbol.DeclaringSyntaxReferences[0].GetSyntax() : null;
         }
 
         private static async Task<Document> ChangeAccessibilityCodeFix(Document document, SyntaxNode root, SyntaxNode nodeToFix, CancellationToken cancellationToken)

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/EnumsShouldHaveZeroValue.cs

@@ -157,7 +157,7 @@ private static void CheckFlags(INamedTypeSymbol namedType, ImmutableArray<IField
 
         private static void CheckNonFlags(INamedTypeSymbol namedType, ImmutableArray<IFieldSymbol> zeroValuedFields, Action<Diagnostic> addDiagnostic)
         {
-            if (zeroValuedFields.Length == 0)
+            if (zeroValuedFields.IsEmpty)
             {
                 // Add a member to {0} that has a value of zero with a suggested name of 'None'.
                 addDiagnostic(namedType.CreateDiagnostic(RuleNoZero, namedType.Name));

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/ImplementIDisposableCorrectly.cs

@@ -304,7 +304,7 @@ private static void CheckRenameDisposeRule(IMethodSymbol method, INamedTypeSymbo
             /// </summary>
             private void CheckDisposeOverrideRule(IMethodSymbol method, INamedTypeSymbol type, SymbolAnalysisContext context)
             {
-                if (method.MethodKind == MethodKind.Ordinary && method.IsOverride && method.ReturnsVoid && method.Parameters.Length == 0)
+                if (method.MethodKind == MethodKind.Ordinary && method.IsOverride && method.ReturnsVoid && method.Parameters.IsEmpty)
                 {
                     bool isDisposeOverride = false;
                     for (IMethodSymbol m = method.OverriddenMethod; m != null; m = m.OverriddenMethod)

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/ImplementStandardExceptionConstructors.cs

@@ -85,7 +85,7 @@ private void AnalyzeCompilationSymbol(CompilationStartAnalysisContext context)
                         var parameters = ctor.GetParameters();
 
                         //case 1: Default constructor - no parameters
-                        if (parameters.Length == 0)
+                        if (parameters.IsEmpty)
                         {
                             defaultConstructorFound = true;
                         }

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/InterfaceMethodsShouldBeCallableByChildTypes.cs

@@ -69,7 +69,7 @@ private static bool ShouldExcludeOperationBlock(ImmutableArray<IOperation> opera
                 }
 
                 var explicitOperations = block.Operations.WithoutFullyImplicitOperations();
-                if (explicitOperations.Length == 0)
+                if (explicitOperations.IsEmpty)
                 {
                     // Empty body.
                     return true;
@@ -100,7 +100,7 @@ private static void AnalyzeOperationBlock(OperationBlockAnalysisContext context,
             var method = (IMethodSymbol)context.OwningSymbol;
 
             // We are only interested in private explicit interface implementations within a public non-sealed type.
-            if (method.ExplicitInterfaceImplementations.Length == 0 ||
+            if (method.ExplicitInterfaceImplementations.IsEmpty ||
                 method.GetResultantVisibility() != SymbolVisibility.Private ||
                 method.ContainingType.IsSealed ||
                 !method.ContainingType.IsExternallyVisible())

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/MarkAssembliesWithComVisible.cs

@@ -63,7 +63,7 @@ private static void AnalyzeCompilation(CompilationAnalysisContext context)
 
                 if (attributeInstance != null)
                 {
-                    if (attributeInstance.ConstructorArguments.Length > 0 &&
+                    if (!attributeInstance.ConstructorArguments.IsEmpty &&
                         attributeInstance.ConstructorArguments[0].Kind == TypedConstantKind.Primitive &&
                         attributeInstance.ConstructorArguments[0].Value != null &
                         attributeInstance.ConstructorArguments[0].Value.Equals(true))

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/ParameterNamesShouldMatchBaseDeclaration.cs

@@ -63,7 +63,7 @@ private static void AnalyzeMethodSymbol(SymbolAnalysisContext analysisContext)
             }
 
             ImmutableArray<IMethodSymbol> originalDefinitions = GetOriginalDefinitions(methodSymbol);
-            if (originalDefinitions.Length == 0)
+            if (originalDefinitions.IsEmpty)
             {
                 // We did not find any original definitions so we don't have to do anything.
                 // This can happen when the method has an override modifier,
@@ -136,7 +136,7 @@ private static ImmutableArray<IMethodSymbol> GetOriginalDefinitions(IMethodSymbo
                 originalDefinitionsBuilder.Add(methodSymbol.OverriddenMethod);
             }
 
-            if (methodSymbol.ExplicitInterfaceImplementations.Length > 0)
+            if (!methodSymbol.ExplicitInterfaceImplementations.IsEmpty)
             {
                 originalDefinitionsBuilder.AddRange(methodSymbol.ExplicitInterfaceImplementations);
             }

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/TypesThatOwnDisposableFieldsShouldBeDisposable.Fixer.cs

@@ -54,7 +54,7 @@ private static async Task<Document> ImplementIDisposable(Document document, Synt
 
             // Find a Dispose method. If one exists make that implement IDisposable, else generate a new method.
             var typeSymbol = model.GetDeclaredSymbol(declaration, cancellationToken) as INamedTypeSymbol;
-            IMethodSymbol? disposeMethod = (typeSymbol?.GetMembers("Dispose"))?.OfType<IMethodSymbol>()?.Where(m => m.Parameters.Length == 0).FirstOrDefault();
+            IMethodSymbol? disposeMethod = (typeSymbol?.GetMembers("Dispose"))?.OfType<IMethodSymbol>()?.Where(m => m.Parameters.IsEmpty).FirstOrDefault();
             if (disposeMethod != null && disposeMethod.DeclaringSyntaxReferences.Length == 1)
             {
                 SyntaxNode memberPartNode = await disposeMethod.DeclaringSyntaxReferences.Single().GetSyntaxAsync(cancellationToken).ConfigureAwait(false);

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/UsePropertiesWhereAppropriate.cs

@@ -48,7 +48,7 @@ public override void Initialize(AnalysisContext analysisContext)
                 if (!(context.OwningSymbol is IMethodSymbol methodSymbol) ||
                     methodSymbol.ReturnsVoid ||
                     methodSymbol.ReturnType.Kind == SymbolKind.ArrayType ||
-                    methodSymbol.Parameters.Length > 0 ||
+                    !methodSymbol.Parameters.IsEmpty ||
                     !methodSymbol.MatchesConfiguredVisibility(context.Options, Rule, context.CancellationToken) ||
                     methodSymbol.IsAccessorMethod() ||
                     !IsPropertyLikeName(methodSymbol.Name))

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/QualityGuidelines/AvoidDuplicateElementInitialization.cs

@@ -54,7 +54,7 @@ private static void AnalyzeOperation(OperationAnalysisContext context)
             {
                 if (objectInitializer.Initializer.Initializers[i] is ISimpleAssignmentOperation assignment &&
                     assignment.Target is IPropertyReferenceOperation propertyReference &&
-                    propertyReference.Arguments.Length != 0)
+                    !propertyReference.Arguments.IsEmpty)
                 {
                     var values = GetConstantArgumentValues(propertyReference.Arguments);
                     if (!values.IsEmpty && !initializedElementIndexes.Add(values))

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/QualityGuidelines/AvoidPropertySelfAssignment.cs

@@ -56,7 +56,7 @@ public override void Initialize(AnalysisContext analysisContext)
                     return;
                 }
 
-                if (operationTarget.Arguments.Length > 0)
+                if (!operationTarget.Arguments.IsEmpty)
                 {
                     // Indexers - compare if all the arguments are identical.
                     for (int i = 0; i < operationTarget.Arguments.Length; i++)

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PInvokeDiagnosticAnalyzer.cs

@@ -163,7 +163,7 @@ public void AnalyzeSymbol(SymbolAnalysisContext context)
 
             private UnmanagedType? GetParameterMarshaling(AttributeData attributeData)
             {
-                if (attributeData.ConstructorArguments.Length > 0)
+                if (!attributeData.ConstructorArguments.IsEmpty)
                 {
                     TypedConstant argument = attributeData.ConstructorArguments.First();
                     if (argument.Type.Equals(_unmanagedType))

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/AvoidZeroLengthArrayAllocations.cs

@@ -57,7 +57,7 @@ public sealed override void Initialize(AnalysisContext context)
                 if (typeSymbol != null && typeSymbol.DeclaredAccessibility == Accessibility.Public)
                 {
                     if (typeSymbol.GetMembers(ArrayEmptyMethodName).FirstOrDefault() is IMethodSymbol methodSymbol && methodSymbol.DeclaredAccessibility == Accessibility.Public &&
-    methodSymbol.IsStatic && methodSymbol.Arity == 1 && methodSymbol.Parameters.Length == 0)
+    methodSymbol.IsStatic && methodSymbol.Arity == 1 && methodSymbol.Parameters.IsEmpty)
                     {
                         ctx.RegisterOperationAction(AnalyzeOperation, OperationKind.ArrayCreation);
                     }
@@ -157,7 +157,7 @@ private static bool IsCompilerGeneratedParamsArray(IArrayCreationOperation array
             }
 
             var parameters = targetSymbol.GetParameters();
-            if (parameters.Length == 0 || !parameters[parameters.Length - 1].IsParams)
+            if (parameters.IsEmpty || !parameters[parameters.Length - 1].IsParams)
             {
                 return false;
             }

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DisposeObjectsBeforeLosingScope.cs

@@ -219,7 +219,7 @@ private static void ComputeDiagnostics(
                 }
 
                 var isNotDisposed = disposeValue.Kind == DisposeAbstractValueKind.NotDisposed ||
-                    (disposeValue.DisposingOrEscapingOperations.Count > 0 &&
+                    (!disposeValue.DisposingOrEscapingOperations.IsEmpty &&
                      disposeValue.DisposingOrEscapingOperations.All(d => d.IsInsideCatchRegion(disposeAnalysisResult.ControlFlowGraph) && !location.GetTopOfCreationCallStackOrCreation().IsInsideCatchRegion(disposeAnalysisResult.ControlFlowGraph)));
                 var isMayBeNotDisposed = !isNotDisposed && (disposeValue.Kind == DisposeAbstractValueKind.MaybeDisposed || disposeValue.Kind == DisposeAbstractValueKind.NotDisposedOrEscaped);
 

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DoNotRaiseReservedExceptionTypes.cs

@@ -88,7 +88,7 @@ public override void Initialize(AnalysisContext analysisContext)
                     ImmutableHashSet<INamedTypeSymbol> tooGenericExceptionSymbols = CreateSymbolSet(compilationStartContext.Compilation, s_tooGenericExceptions);
                     ImmutableHashSet<INamedTypeSymbol> reservedExceptionSymbols = CreateSymbolSet(compilationStartContext.Compilation, s_reservedExceptions); ;
 
-                    if (tooGenericExceptionSymbols.Count == 0 && reservedExceptionSymbols.Count == 0)
+                    if (tooGenericExceptionSymbols.IsEmpty && reservedExceptionSymbols.IsEmpty)
                     {
                         return;
                     }

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/InstantiateArgumentExceptionsCorrectly.cs

@@ -70,7 +70,7 @@ private static void AnalyzeObjectCreation(
                 return;
             }
 
-            if (creation.Arguments.Length == 0)
+            if (creation.Arguments.IsEmpty)
             {
                 if (HasMessageOrParameterNameConstructor(creation.Type))
                 {

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/SpecifyStringComparison.cs

@@ -102,7 +102,7 @@ public override void Initialize(AnalysisContext analysisContext)
                         return;
                     }
 
-                    if (overloadMap.Count != 0 && overloadMap.ContainsKey(targetMethod))
+                    if (!overloadMap.IsEmpty && overloadMap.ContainsKey(targetMethod))
                     {
                         ReportDiagnostic(
                             oaContext,

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/TestForEmptyStringsUsingStringLength.cs

@@ -58,7 +58,7 @@ public sealed override void Initialize(AnalysisContext context)
         /// </summary>
         private static void AnalyzeInvocationExpression(IInvocationOperation invocationOperation, Action<Diagnostic> reportDiagnostic)
         {
-            if (invocationOperation.Arguments.Length > 0)
+            if (!invocationOperation.Arguments.IsEmpty)
             {
                 IMethodSymbol methodSymbol = invocationOperation.TargetMethod;
                 if (methodSymbol != null &&

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotCallDangerousMethodsInDeserialization.cs

@@ -206,7 +206,7 @@ public sealed override void Initialize(AnalysisContext context)
                                 // This includes methods with OnDeserializing attribute, method with OnDeserialized attribute, deserialization callbacks as well as cleanup/dispose calls.
                                 var flagSerializable = methodSymbol.ContainingType.HasAttribute(serializableAttributeTypeSymbol);
                                 var parameters = methodSymbol.GetParameters();
-                                var flagHasDeserializeAttributes = attributeTypeSymbols.Length != 0
+                                var flagHasDeserializeAttributes = !attributeTypeSymbols.IsEmpty
                                     && attributeTypeSymbols.Any(s => methodSymbol.HasAttribute(s))
                                     && parameters.Length == 1
                                     && parameters[0].Type.Equals(streamingContextTypeSymbol);

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotDisableHttpClientCRLCheck.cs

@@ -158,7 +158,7 @@ public override void Initialize(AnalysisContext context)
 
                                     if (objectCreationOperation.Type.GetBaseTypesAndThis().Contains(httpClientTypeSymbol))
                                     {
-                                        if (objectCreationOperation.Arguments.Length != 0)
+                                        if (!objectCreationOperation.Arguments.IsEmpty)
                                         {
                                             lock (rootOperationsNeedingAnalysis)
                                             {

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotInstallRootCert.cs

@@ -94,7 +94,7 @@ public override void Initialize(AnalysisContext context)
                         {
                             var kind = PropertySetAbstractValueKind.Unflagged;
 
-                            if (constructorMethod.Parameters.Length > 0)
+                            if (!constructorMethod.Parameters.IsEmpty)
                             {
                                 if (constructorMethod.Parameters[0].Type.Equals(storeNameTypeSymbol))
                                 {

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotUseCreateEncryptorWithNonDefaultIV.cs

@@ -63,7 +63,7 @@ public sealed class DoNotUseCreateEncryptorWithNonDefaultIV : DiagnosticAnalyzer
                     // The passed rgbIV can't be null cause CreateEncryptor method has an ANE exception.
                     // It definitely uses a non-default IV and will be flagged a diagnostic directly without PropertySetAnalysis.
                     // So, it returns Unflagged to avoid repeated diagnostic.
-                    if (methodSymbol.Parameters.Length != 0)
+                    if (!methodSymbol.Parameters.IsEmpty)
                     {
                         return HazardousUsageEvaluationResult.Unflagged;
                     }
@@ -116,7 +116,7 @@ public override void Initialize(AnalysisContext context)
                                     if (methodSymbol.ContainingType.GetBaseTypesAndThis().Contains(symmetricAlgorithmTypeSymbol) &&
                                         methodSymbol.Name == "CreateEncryptor")
                                     {
-                                        if (methodSymbol.Parameters.Length == 0)
+                                        if (methodSymbol.Parameters.IsEmpty)
                                         {
                                             lock (rootOperationsNeedingAnalysis)
                                             {

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotUseDSA.cs

@@ -132,7 +132,7 @@ public override void Initialize(AnalysisContext context)
 
                     if (methodName == "Create" &&
                         typeSymbol.Equals(asymmetricAlgorithmTypeSymbol) &&
-                        arguments.Length > 0 &&
+                        !arguments.IsEmpty &&
                         arguments[0].Parameter.Type.SpecialType == SpecialType.System_String &&
                         arguments[0].Value.ConstantValue.HasValue)
                     {
@@ -148,7 +148,7 @@ public override void Initialize(AnalysisContext context)
                     }
                     else if (methodName == "CreateFromName" &&
                             typeSymbol.Equals(cryptoConfigTypeSymbol) &&
-                            arguments.Length > 0 &&
+                            !arguments.IsEmpty &&
                             arguments[0].Parameter.Type.SpecialType == SpecialType.System_String &&
                             arguments[0].Value.ConstantValue.HasValue)
                     {

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotUseInsecureDeserializerJavascriptSerializerWithSimpleTypeResolver.cs

@@ -89,7 +89,7 @@ public override void Initialize(AnalysisContext context)
                         (IMethodSymbol constructorMethod, IReadOnlyList<PointsToAbstractValue> argumentPointsToAbstractValues) =>
                         {
                             PropertySetAbstractValueKind kind;
-                            if (constructorMethod.Parameters.Length == 0)
+                            if (constructorMethod.Parameters.IsEmpty)
                             {
                                 kind = PropertySetAbstractValueKind.Unflagged;
                             }

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotUseInsecureDeserializerJsonNetWithoutBinder.cs

@@ -62,7 +62,7 @@ internal class DoNotUseInsecureDeserializerJsonNetWithoutBinder : DiagnosticAnal
         private static readonly ConstructorMapper ConstructorMapper = new ConstructorMapper(
             (IMethodSymbol constructorMethod, IReadOnlyList<PointsToAbstractValue> argumentPointsToAbstractValues) =>
             {
-                if (constructorMethod.Parameters.Length == 0)
+                if (constructorMethod.Parameters.IsEmpty)
                 {
                     return PropertySetAbstractValue.GetInstance(
                         PropertySetAbstractValueKind.Unflagged,   // TypeNameHandling defaults to None.

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotUseInsecureSettingsForJsonNet.cs

@@ -61,7 +61,7 @@ public sealed class DoNotUseInsecureSettingsForJsonNet : DiagnosticAnalyzer
         private static readonly ConstructorMapper ConstructorMapper = new ConstructorMapper(
             (IMethodSymbol constructorMethod, IReadOnlyList<PointsToAbstractValue> argumentPointsToAbstractValues) =>
             {
-                if (constructorMethod.Parameters.Length == 0)
+                if (constructorMethod.Parameters.IsEmpty)
                 {
                     return PropertySetAbstractValue.GetInstance(
                         PropertySetAbstractValueKind.Unflagged,   // TypeNameHandling defaults to None.