Skip to content

[VS Code] [Cohosting] Override completion doesn't work #11840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidwengier opened this issue May 8, 2025 · 0 comments
Open

[VS Code] [Cohosting] Override completion doesn't work #11840

davidwengier opened this issue May 8, 2025 · 0 comments

Comments

@davidwengier
Copy link
Member

We don't currently advertise for resolve, which might be a problem, but even if we do, things don't work. The current completion code we have happily re-writes the Data property of the completion item it receives, and also the one(s) it sends back. In VS this is fine as there is a serialization boundary between the LSP handler and the OOP service, but in VS Code there is no such boundary, so Roslyn ends up with cached result ids that are from our cache, and don't match etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants