Remove cancellation support

AsyncLazy doesn't pass a cancellation token to the func. I tried to work around this with a CTS, but that doesn't work. If one caller cancels, it'll cancel all other callers, which isn't correct. Instead, we remove cancellation from the GetService calls, as these are cheap and cancellation is unlikely. Anyone waiting on the value would be correctly cancelled still.

Author: drewnoakes

src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/UpToDate/UpToDateCheckHost.cs

@@ -12,9 +12,7 @@ internal sealed class UpToDateCheckHost : IUpToDateCheckHost
     {
         private readonly IVsService<IVsAppId> _vsAppId;
         private readonly IVsService<IVsAppCommandLine> _vsAppCommandLine;
-
         private readonly AsyncLazy<bool> _hasDesignTimeBuild;
-        private readonly CancellationTokenSource _cancellationTokenSource = new();
 
         [ImportingConstructor]
         public UpToDateCheckHost(
@@ -30,16 +28,12 @@ public UpToDateCheckHost(
 
         public async ValueTask<bool> HasDesignTimeBuildsAsync(CancellationToken cancellationToken)
         {
-            cancellationToken.Register(_cancellationTokenSource.Cancel);
-
             return await _hasDesignTimeBuild.GetValueAsync(cancellationToken);
         }
 
         private async Task<bool> HasDesignTimeBuildsInternalAsync()
         {
-            CancellationToken token = _cancellationTokenSource.Token;
-
-            IVsAppCommandLine vsAppCommandLine = await _vsAppCommandLine.GetValueAsync(token);
+            IVsAppCommandLine vsAppCommandLine = await _vsAppCommandLine.GetValueAsync();
 
             if (ErrorHandler.Succeeded(vsAppCommandLine.GetOption("populateSolutionCache", out int populateSolutionCachePresent, out string _)))
             {
@@ -50,7 +44,7 @@ private async Task<bool> HasDesignTimeBuildsInternalAsync()
                 }
             }
 
-            IVsAppId vsAppId = await _vsAppId.GetValueAsync(token);
+            IVsAppId vsAppId = await _vsAppId.GetValueAsync();
 
             if (ErrorHandler.Succeeded(vsAppId.GetProperty((int)__VSAPROPID10.VSAPROPID_IsInCommandLineMode, out object value)))
             {