Unblock JavaScript projects to load (#9708)

* Unblock JavaScript projects to load

The launch setting provider is loaded in JavaScript earlier than configured project is loaded, due to how it adds the capability
(through its factory). It leads GetLaunchSettingsFilePathNoCacheAsync called before active configured project is loaded and leads NFE.

This PR is to wait configured project to load before accessing project properties.

* Update unit test Moq.

* Add some comments to the code changed.

---------

Co-authored-by: Lifeng Lu <[email protected]>

Author: lifengl

src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/Debug/LaunchSettingsProvider.cs

@@ -873,6 +873,14 @@ internal async Task<string> GetLaunchSettingsFilePathNoCacheAsync()
         // even though it can change over the lifetime of the project. We should fix this and convert to using dataflow
         // see: https://github.com/dotnet/project-system/issues/2316.
 
+        if (_project.Services.ActiveConfiguredProjectProvider is IActiveConfiguredProjectProvider activeConfiguredProjectProvider &&
+            activeConfiguredProjectProvider.ActiveConfiguredProject is null)
+        {
+            // in a project system the LauchProfile is turned on through project factory, the provider can be initialized before configuration is loaded.
+            // Because _projectProperties is depending on the active configured project, it will end up with NFE failure.
+            await activeConfiguredProjectProvider.ActiveConfiguredProjectBlock.ReceiveAsync(_project.Services.ProjectAsynchronousTasks?.UnloadCancellationToken ?? CancellationToken.None);
+        }
+
         // Default to the project directory if we're not able to get the AppDesigner folder.
         string folder = _commonProjectServices.Project.GetProjectDirectory();
 

tests/Microsoft.VisualStudio.ProjectSystem.Managed.UnitTests/ProjectSystem/Debug/LaunchSettingsProviderTests.cs

@@ -22,7 +22,8 @@ internal static LaunchSettingsUnderTest GetLaunchSettingsProvider(IFileSystem? f
 
         var projectProperties = ProjectPropertiesFactory.Create(AppDesigner.SchemaName, AppDesigner.FolderNameProperty, appDesignerFolder);
         var activeConfigurationProjectProperties = IActiveConfiguredValueFactory.ImplementValue<ProjectProperties?>(() => projectProperties);
-        var project = UnconfiguredProjectFactory.Create(fullPath: @"c:\test\Project1\Project1.csproj");
+        var configuredProject = ConfiguredProjectFactory.Create();
+        var project = UnconfiguredProjectFactory.Create(fullPath: @"c:\test\Project1\Project1.csproj", configuredProject: configuredProject);
         var properties = ProjectPropertiesFactory.Create(project, [debuggerData]);
         var threadingService = IProjectThreadingServiceFactory.Create();
         var commonServices = IUnconfiguredProjectCommonServicesFactory.Create(project, threadingService, null, properties);