Skip to content

Commit 6a4f315

Browse files
authored
Disable packing in bootstrap build (#11133)
1 parent 8c0edd2 commit 6a4f315

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

eng/TestAssets.targets

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,15 @@
2323
Inputs="@(ProjectsToPack);@(SourceFilesForPacking)"
2424
Outputs="$(ArtifactsNonShippingPackagesDir)\Microsoft.Build.$(Version).nupkg;$(ArtifactsNonShippingPackagesDir)\Microsoft.Build.Framework.$(Version).nupkg;$(ArtifactsNonShippingPackagesDir)\Microsoft.NET.StringTools.$(Version).nupkg">
2525

26-
<MSBuild Projects="@(ProjectsToPack)"
26+
<!--
27+
Temporarily disabling the packing within bootstrap build, until #11090 is resolved
28+
<MSBuild Projects="@(ProjectsToPack)"
2729
Targets="Pack"
2830
Properties="PackageOutputPath=$(ArtifactsNonShippingPackagesDir);PackageVersion=$(PackageVersion)"
2931
BuildInParallel="true">
3032
<Output TaskParameter="TargetOutputs" ItemName="PackageOutputs" />
3133
</MSBuild>
34+
-->
3235

3336
</Target>
3437
</Project>

src/BuildCheck.UnitTests/EndToEndTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Licensed to the .NET Foundation under one or more agreements.
1+
// Licensed to the .NET Foundation under one or more agreements.
22
// The .NET Foundation licenses this file to you under the MIT license.
33

44
using System;
@@ -579,7 +579,7 @@ public void EditorConfig_SeverityAppliedCorrectly(string BC0101Severity, string?
579579
}
580580
}
581581

582-
[Fact]
582+
[Fact(Skip = "To unblock: https://github.com/dotnet/msbuild/issues/11090")]
583583
public void CheckHasAccessToAllConfigs()
584584
{
585585
using (var env = TestEnvironment.Create())
@@ -757,7 +757,7 @@ public void NoEnvironmentVariableProperty_DeferredProcessing(bool warnAsError, b
757757
}
758758
}
759759

760-
[Theory]
760+
[Theory(Skip = "To unblock: https://github.com/dotnet/msbuild/issues/11090")]
761761
[InlineData("CheckCandidate", new[] { "CustomRule1", "CustomRule2" })]
762762
[InlineData("CheckCandidateWithMultipleChecksInjected", new[] { "CustomRule1", "CustomRule2", "CustomRule3" }, true)]
763763
public void CustomCheckTest_NoEditorConfig(string checkCandidate, string[] expectedRegisteredRules, bool expectedRejectedChecks = false)
@@ -790,7 +790,7 @@ public void CustomCheckTest_NoEditorConfig(string checkCandidate, string[] expec
790790
}
791791
}
792792

793-
[Theory]
793+
[Theory(Skip = "To unblock: https://github.com/dotnet/msbuild/issues/11090")]
794794
[InlineData("CheckCandidate", "X01234", "error", "error X01234: http://samplelink.com/X01234")]
795795
[InlineData("CheckCandidateWithMultipleChecksInjected", "X01234", "warning", "warning X01234: http://samplelink.com/X01234")]
796796
public void CustomCheckTest_WithEditorConfig(string checkCandidate, string ruleId, string severity, string expectedMessage)
@@ -817,7 +817,7 @@ public void CustomCheckTest_WithEditorConfig(string checkCandidate, string ruleI
817817
}
818818
}
819819

820-
[Theory]
820+
[Theory(Skip = "To unblock: https://github.com/dotnet/msbuild/issues/11090")]
821821
[InlineData("X01236", "ErrorOnInitializeCheck", "Something went wrong initializing")]
822822
[InlineData("X01237", "ErrorOnRegisteredAction", "something went wrong when executing registered action")]
823823
[InlineData("X01238", "ErrorWhenRegisteringActions", "something went wrong when registering actions")]
@@ -867,7 +867,7 @@ public void DoesNotRunOnRestore(bool buildInOutOfProcessNode)
867867
}
868868

869869
#if NET
870-
[Fact]
870+
[Fact(Skip = "To unblock: https://github.com/dotnet/msbuild/issues/11090")]
871871
public void TestBuildCheckTemplate()
872872
{
873873
TransientTestFolder workFolder = _env.CreateFolder(createFolder: true);

0 commit comments

Comments
 (0)