Skip to content

Commit 09a6fe4

Browse files
Revert "Remove Conversion.Core registrations (#10817)"
This reverts commit b8f46eb.
1 parent b8f46eb commit 09a6fe4

File tree

7 files changed

+22
-0
lines changed

7 files changed

+22
-0
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
[$RootKey$\RuntimeConfiguration\dependentAssembly\bindingRedirection\{69CFFD1A-343F-46C5-81B3-8437CD1272CD}]
2+
"name"="Microsoft.Build.Conversion.Core"
3+
"codeBase"="$BaseInstallDir$\MSBuild\Current\Bin\Microsoft.Build.Conversion.Core.dll"
4+
"publicKeyToken"="b03f5f7f11d50a3a"
5+
"culture"="neutral"
6+
"oldVersion"="0.0.0.0-99.9.9.9"
7+
"newVersion"="15.1.0.0"

src/Package/DevDivPackage/DevDivPackage.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<ItemGroup>
1515
<ProjectReference Include="..\..\MSBuild\MSBuild.csproj" />
1616
<ProjectReference Include="..\..\Framework\Microsoft.Build.Framework.csproj" />
17+
<ProjectReference Include="..\..\Deprecated\Conversion\Microsoft.Build.Conversion.csproj" />
1718
<ProjectReference Include="..\..\Deprecated\Engine\Microsoft.Build.Engine.csproj" />
1819
</ItemGroup>
1920

src/Package/DevDivPackage/VS.ExternalAPIs.MSBuild.nuspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
<!-- Obsolete but still referenced in the VS repo -->
2424
<file src="Microsoft.Build.Engine.dll" target="lib\net472" />
25+
<file src="Microsoft.Build.Conversion.Core.dll" target="lib\net472" />
2526

2627
<file src="Microsoft.Build.tlb" target="lib\net472" />
2728
<file src="Microsoft.Build.Framework.tlb" target="lib\net472" />

src/Package/GetBinPaths.targets

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@
1919
ReferenceOutputAssembly="false"
2020
OutputItemType="MSBuildTaskHostResolvedProjectReferencePath" />
2121

22+
<ProjectReference Include="$(MSBuildThisFileDirectory)\..\Deprecated\Conversion\Microsoft.Build.Conversion.csproj"
23+
Private="false"
24+
ReferenceOutputAssembly="false"
25+
OutputItemType="MSBuildConversionResolvedProjectReferencePath" />
26+
2227
<!-- Set up items to build projects where the Platform is set to x64, when we need the x64 versions of the files.
2328
We have to treat these separately from normal project references, as the AssignProjectConfiguration task would overwrite
2429
the SetPlatform item metadata if they were ProjectReferences.
@@ -49,6 +54,7 @@
4954
<FrameworkBinPath>@(FrameworkResolvedProjectReferencePath->'%(RootDir)%(Directory)')</FrameworkBinPath>
5055
<MSBuildTaskHostBinPath>@(MSBuildTaskHostResolvedProjectReferencePath->'%(RootDir)%(Directory)')</MSBuildTaskHostBinPath>
5156
<MSBuildTaskHostX64BinPath>@(MSBuildTaskHostX64ResolvedProjectReferencePath->'%(RootDir)%(Directory)')</MSBuildTaskHostX64BinPath>
57+
<MSBuildConversionBinPath>@(MSBuildConversionResolvedProjectReferencePath->'%(RootDir)%(Directory)')</MSBuildConversionBinPath>
5258
</PropertyGroup>
5359
</Target>
5460

src/Package/MSBuild.VSSetup/MSBuild.VSSetup.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
<SwrProperty Include="FrameworkBinPath=$(FrameworkBinPath)" />
3838
<SwrProperty Include="TaskHostBinPath=$(MSBuildTaskHostBinPath)" />
3939
<SwrProperty Include="TaskHostX64BinPath=$(MSBuildTaskHostX64BinPath)" />
40+
<SwrProperty Include="MSBuildConversionBinPath=$(MSBuildConversionBinPath)" />
4041
</ItemGroup>
4142
</Target>
4243

src/Package/MSBuild.VSSetup/MSBuild.clientenabledpkg

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@ Microsoft.Build.pkgdef
33
Microsoft.Build.Tasks.Core.pkgdef
44
System.Resources.Extensions.pkgdef
55
Microsoft.Build.Utilities.Core.pkgdef
6+
Microsoft.Build.Conversion.Core.pkgdef
67
Microsoft.Build.Engine.pkgdef

src/Package/MSBuild.VSSetup/files.swr

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ folder InstallDir:\MSBuild\Current
2626
file source=$(ThirdPartyNotice)
2727

2828
folder InstallDir:\MSBuild\Current\Bin
29+
file source=$(MSBuildConversionBinPath)Microsoft.Build.Conversion.Core.dll vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe" vs.file.ngenApplications="[installDir]\MSBuild\Current\Bin\MSBuild.exe" vs.file.ngenArchitecture=all
2930
file source=$(X86BinPath)Microsoft.Build.dll vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe" vs.file.ngenApplications="[installDir]\MSBuild\Current\Bin\MSBuild.exe" vs.file.ngenArchitecture=all vs.file.ngenPriority=1
31+
file source=$(MSBuildConversionBinPath)Microsoft.Build.Engine.dll vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe" vs.file.ngenApplications="[installDir]\MSBuild\Current\Bin\MSBuild.exe" vs.file.ngenArchitecture=all
3032
file source=$(X86BinPath)Microsoft.Build.Framework.dll vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe" vs.file.ngenApplications="[installDir]\MSBuild\Current\Bin\MSBuild.exe" vs.file.ngenArchitecture=all
3133
file source=$(X86BinPath)Microsoft.Build.Framework.tlb
3234
file source=$(X86BinPath)Microsoft.Build.Tasks.Core.dll vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe" vs.file.ngenApplications="[installDir]\MSBuild\Current\Bin\MSBuild.exe" vs.file.ngenArchitecture=all vs.file.ngenPriority=1
@@ -182,7 +184,9 @@ folder InstallDir:\MSBuild\Current\Bin\amd64
182184
file source=$(X64BinPath)MSBuild.exe.config
183185
file source=$(TaskHostX64BinPath)MSBuildTaskHost.exe.config
184186

187+
file source=$(MSBuildConversionBinPath)Microsoft.Build.Conversion.Core.dll vs.file.ngenArchitecture=all
185188
file source=$(X86BinPath)Microsoft.Build.dll vs.file.ngenArchitecture=all
189+
file source=$(MSBuildConversionBinPath)Microsoft.Build.Engine.dll vs.file.ngenArchitecture=all
186190
file source=$(X86BinPath)Microsoft.Build.Framework.dll vs.file.ngenArchitecture=all
187191
file source=$(FrameworkBinPath)x64\Microsoft.Build.Framework.tlb
188192
file source=$(X86BinPath)Microsoft.Build.Tasks.Core.dll vs.file.ngenArchitecture=all
@@ -331,4 +335,5 @@ folder InstallDir:\Common7\IDE\CommonExtensions\MSBuild
331335
file source=$(SourceDir)Tasks\Microsoft.Build.Tasks.Core.pkgdef
332336
file source=$(SourceDir)Tasks\System.Resources.Extensions.pkgdef
333337
file source=$(SourceDir)Utilities\Microsoft.Build.Utilities.Core.pkgdef
338+
file source=$(SourceDir)Deprecated\Conversion\Microsoft.Build.Conversion.Core.pkgdef
334339
file source=$(SourceDir)Deprecated\Engine\Microsoft.Build.Engine.pkgdef

0 commit comments

Comments
 (0)