Add support for hexadecimal values (like 0xFF) ​​to msbuild property BaseAddress

This was a bug, because loading a project with

    <BaseAddress>0x06800000</BaseAddress>

the property value was silently ignored

Author: enricosada

vsintegration/src/unittests/Tests.ProjectSystem.Miscellaneous.fs

@@ -768,6 +768,15 @@ type Utilities() =
         ()
 
 
+    [<Test>]
+    member public this.``Parse MSBuild property of type Int64`` () = 
+        Assert.AreEqual(123L, ProjectNode.ParsePropertyValueToInt64("123"))
+        Assert.AreEqual(255L, ProjectNode.ParsePropertyValueToInt64("0xFF"))
+        Assert.AreEqual(null, ProjectNode.ParsePropertyValueToInt64(""))
+        Assert.AreEqual(null, ProjectNode.ParsePropertyValueToInt64(null))
+        Assert.Throws<Exception>(fun () -> ignore (ProjectNode.ParsePropertyValueToInt64("abc"))) |> ignore
+        Assert.Throws<Exception>(fun () -> ignore (ProjectNode.ParsePropertyValueToInt64("12333333333333333333333333"))) |> ignore
+
 
 #if DEBUGGERVISUALIZER
 module internal DebugViz =

vsintegration/src/vs/FsPkgs/FSharp.Project/Common.Source.CSharp/Project/ProjectNode.cs

@@ -2560,6 +2560,24 @@ public virtual void SetOrCreateBuildEventProperty(string propertyName, string pr
             }
         }
 
+        /// <remarks>Support hex format (like 0xFF)</remarks>
+        /// <exception cref="System.Exception">
+        /// Raise if invalid format
+        /// The inner exception contains the real exception, of type FormatException, StackOverflowException
+        /// </exception>
+        public static long? ParsePropertyValueToInt64(string s)
+        {
+            if (string.IsNullOrWhiteSpace(s))
+                return null;
+
+            var converter = new System.ComponentModel.Int64Converter();
+            var result = converter.ConvertFromInvariantString(s);
+            if (result == null)
+                return null;
+
+            return (long) result;
+        }
+
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase")]
         internal virtual ProjectOptions GetProjectOptions(ConfigCanonicalName configCanonicalName)
         {
@@ -2638,28 +2656,16 @@ internal virtual ProjectOptions GetProjectOptions(ConfigCanonicalName configCano
                 options.AllowUnsafeCode = true;
             }
 
-            if (GetProjectProperty("BaseAddress", false) != null)
+            string baseAddressPropertyString = GetProjectProperty("BaseAddress", false);
+            try
             {
-                try
-                {
-                    options.BaseAddress = Int64.Parse(GetProjectProperty("BaseAddress", false), CultureInfo.InvariantCulture);
-                }
-                catch (ArgumentNullException e)
-                {
-                    Trace.WriteLine("Exception : " + e.Message);
-                }
-                catch (ArgumentException e)
-                {
-                    Trace.WriteLine("Exception : " + e.Message);
-                }
-                catch (FormatException e)
-                {
-                    Trace.WriteLine("Exception : " + e.Message);
-                }
-                catch (OverflowException e)
-                {
-                    Trace.WriteLine("Exception : " + e.Message);
-                }
+                var result = ParsePropertyValueToInt64(baseAddressPropertyString);
+                if (result.HasValue)
+                    options.BaseAddress = result.Value;
+            }
+            catch (Exception e)
+            {
+                Trace.WriteLine(string.Format("Exception parsing property {0}='{1}': {2}", "BaseAddress", baseAddressPropertyString, e.Message));
             }
 
             if (GetBoolAttr("CheckForOverflowUnderflow"))