Skip to content

Commit 7866d66

Browse files
authored
React to NuGet package pruning warnings (#18304)
Contributes to dotnet/sdk#46642 NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.
1 parent 8e773e7 commit 7866d66

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

eng/Versions.props

-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@
8787
<SystemReflectionMetadataVersion>$(SystemPackageVersionVersion)</SystemReflectionMetadataVersion>
8888
<SystemRuntimeCompilerServicesUnsafeVersion>6.1.0</SystemRuntimeCompilerServicesUnsafeVersion>
8989
<SystemThreadingTasksDataflow>$(SystemPackageVersionVersion)</SystemThreadingTasksDataflow>
90-
<SystemValueTupleVersion>4.5.0</SystemValueTupleVersion>
9190
<MicrosoftDiaSymReaderPortablePdbVersion>1.6.0</MicrosoftDiaSymReaderPortablePdbVersion>
9291
<!-- Versions for package groups -->
9392
<RoslynVersion>4.11.0-2.24264.2</RoslynVersion>

src/fsc/fsc.targets

+6-3
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,16 @@
4545
</ItemGroup>
4646

4747
<ItemGroup>
48+
<PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildFrameworkVersion)" />
49+
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" />
50+
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildUtilitiesCoreVersion)" />
51+
</ItemGroup>
52+
53+
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">
4854
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="$(SystemDiagnosticsDiagnosticSourceVersion)" />
4955
<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />
5056
<PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="$(SystemRuntimeCompilerServicesUnsafeVersion)" />
5157
<PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataVersion)" />
52-
<PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildFrameworkVersion)" />
53-
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" />
54-
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildUtilitiesCoreVersion)" />
5558
</ItemGroup>
5659

5760
</Project>

0 commit comments

Comments
 (0)