Skip to content

Commit c5aae01

Browse files
committed
Clean up version checks in tests
1 parent 8d775f5 commit c5aae01

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/Microsoft.DotNet.Docker.Tests/ImageScenarioVerifier.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public ImageScenarioVerifier(
3737
_imageData = imageData;
3838
_isWeb = isWeb;
3939
_outputHelper = outputHelper;
40-
_nonRootUserSupported = DockerHelper.IsLinuxContainerModeEnabled && _imageData.Version.Major != 6 && _imageData.Version.Major != 7;
40+
_nonRootUserSupported = DockerHelper.IsLinuxContainerModeEnabled && _imageData.Version.Major >= 7;
4141
}
4242

4343
public async Task Execute()
@@ -59,7 +59,7 @@ public async Task Execute()
5959
// Use `sdk` image to build and run test app
6060
string buildTag = BuildTestAppImage("build", solutionDir, customBuildArgs);
6161
tags.Add(buildTag);
62-
string dotnetRunArgs = _isWeb && (_imageData.Version.Major == 6 || _imageData.Version.Major == 7) ? $" --urls http://0.0.0.0:{_imageData.DefaultPort}" : string.Empty;
62+
string dotnetRunArgs = _isWeb && _imageData.Version.Major <= 7 ? $" --urls http://0.0.0.0:{_imageData.DefaultPort}" : string.Empty;
6363
await RunTestAppImage(buildTag, command: $"dotnet run");
6464
}
6565

@@ -338,7 +338,7 @@ private async Task RunTestAppImage(string image, string user = null, string comm
338338

339339
public static async Task<HttpResponseMessage> GetHttpResponseFromContainerAsync(string containerName, DockerHelper dockerHelper, ITestOutputHelper outputHelper, int containerPort, string pathAndQuery = null, Action<HttpResponseMessage> validateCallback = null, AuthenticationHeaderValue authorizationHeader = null)
340340
{
341-
int retries = 30;
341+
int retries = 32;
342342

343343
// Can't use localhost when running inside containers or Windows.
344344
string url = !Config.IsRunningInContainer && DockerHelper.IsLinuxContainerModeEnabled

0 commit comments

Comments
 (0)