Skip to content

Commit 74bdb8b

Browse files
authored
Add registry search for upgrade policy keys (#57952)
* Add registry search for upgrade policy keys * SharedFx bundle too * Add util extension * Another fix
1 parent f4ee6c1 commit 74bdb8b

File tree

5 files changed

+18
-2
lines changed

5 files changed

+18
-2
lines changed

src/Installers/Windows/SharedFrameworkBundle/Bundle.wxs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi" xmlns:dep="http://schemas.microsoft.com/wix/DependencyExtension" xmlns:bal="http://schemas.microsoft.com/wix/BalExtension">
2+
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi" xmlns:util="http://schemas.microsoft.com/wix/UtilExtension"
3+
xmlns:dep="http://schemas.microsoft.com/wix/DependencyExtension" xmlns:bal="http://schemas.microsoft.com/wix/BalExtension">
34
<Bundle Name="$(var.BundleName)" Version="$(var.BundleVersion)" Manufacturer="Microsoft Corporation" UpgradeCode="$(var.BundleUpgradeCode)">
45
<BootstrapperApplicationRef Id="WixStandardBootstrapperApplication.HyperlinkLicense">
56
<bal:WixStandardBootstrapperApplication LicenseUrl="https://go.microsoft.com/fwlink/?LinkId=329770"
@@ -11,6 +12,10 @@
1112
<PayloadGroupRef Id="PG_Resources"/>
1213
</BootstrapperApplicationRef>
1314

15+
<util:RegistrySearchRef Id="RemovePreviousVersionRegistryKeySearch"/>
16+
<util:RegistrySearchRef Id="RemoveSpecificPreviousVersionRegistryKeyExistsSearch"/>
17+
<util:RegistrySearchRef Id="RemoveSpecificPreviousVersionRegistryKeySearch"/>
18+
1419
<!-- Ensure upgrades from 3.0.0 preview 1, 2, and 3. Conditioned for the 3.0.0 family. -->
1520
<?if $(var.Version)=3.0.0.0?>
1621
<?if $(var.Platform)=x86?>

src/Installers/Windows/SharedFrameworkBundle/SharedFrameworkBundle.wixproj

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
</PropertyGroup>
1414

1515
<ItemGroup>
16+
<WixExtension Include="WixUtilExtension">
17+
<HintPath>$(WixExtDir)\WixUtilExtension.dll</HintPath>
18+
<Name>WixUtilExtension</Name>
19+
</WixExtension>
1620
<WixExtension Include="WixDependencyExtension">
1721
<HintPath>$(WixExtDir)\WixDependencyExtension.dll</HintPath>
1822
<Name>WixDependencyExtension</Name>
@@ -25,6 +29,7 @@
2529

2630
<ItemGroup>
2731
<Compile Include="Bundle.wxs" />
32+
<Compile Include="$(PkgMicrosoft_DotNet_Build_Tasks_Installers)\build\wix\bundle\upgradePolicies.wxs" />
2833
<Content Include="thm.xml" />
2934
</ItemGroup>
3035

src/Installers/Windows/WindowsHostingBundle/Bundle.wxs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@
1313
<PayloadGroupRef Id="PG_Resources"/>
1414
</BootstrapperApplicationRef>
1515

16+
<!-- Search references for upgrade policy keys -->
17+
<util:RegistrySearchRef Id="RemovePreviousVersionRegistryKeySearch"/>
18+
<util:RegistrySearchRef Id="RemoveSpecificPreviousVersionRegistryKeyExistsSearch"/>
19+
<util:RegistrySearchRef Id="RemoveSpecificPreviousVersionRegistryKeySearch"/>
20+
1621
<!-- Ensure upgrades from 3.0.0 preview 1 and 2 (Preview 3 was not shipped). Conditioned for the 3.0.0 family. Hosting bundle simships x86/x64 so there's
1722
a single set of upgrade codes. -->
1823
<?if $(var.Version)=3.0.0.0?>

src/Installers/Windows/WindowsHostingBundle/WindowsHostingBundle.wixproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
<Compile Include="Bundle.wxs" />
3737
<Compile Include="DotNetCore.wxs" />
3838
<Compile Include="SharedFramework.wxs" />
39+
<Compile Include="$(PkgMicrosoft_DotNet_Build_Tasks_Installers)\build\wix\bundle\upgradePolicies.wxs" />
3940
</ItemGroup>
4041

4142
<ItemGroup>

src/Installers/Windows/Wix.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
NoLogo="true"
111111
Cultures="en-us"
112112
InstallerFile="%(WixInstallerFilesToProcess.Identity)"
113-
AdditionalBasePaths="$(MSBuildProjectDirectory)"
113+
AdditionalBasePaths="$(MSBuildProjectDirectory);$(PkgMicrosoft_DotNet_Build_Tasks_Installers)\build\wix\bundle"
114114
WixExtensions="@(WixExtension)"
115115
Loc="@(EmbeddedResource)"
116116
Sice="$(SuppressIces)"

0 commit comments

Comments
 (0)