You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in the 6.x series the NeutralResourcesLanguageAttribute is missing from the netfx assembly (regression of #426)
I think it was after csproj was converted to sdk style in #2413, as the way of overriding BeforeBuild (in GenerateAssemblyInfo.targets) doesn't work with implicit targets (dotnet/msbuild#9327)
You can also see this in the msbuild log:
Overriding target "BeforeBuild" in project "C:\Users\Brad\Code\SqlClient\src\Microsoft.Data.SqlClient\netfx\tools\targets\GenerateAssemblyInfo.targets" with target "BeforeBuild" from project "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets".
In the same contexts as the original issue, when the assembly is loaded, tries to locate the en-us dll and fails
To reproduce
Inspect the produced dll, missing assembly attribute
Describe the bug
in the 6.x series the
NeutralResourcesLanguageAttribute
is missing from the netfx assembly (regression of #426)I think it was after csproj was converted to sdk style in #2413, as the way of overriding
BeforeBuild
(inGenerateAssemblyInfo.targets
) doesn't work with implicit targets (dotnet/msbuild#9327)You can also see this in the msbuild log:
In the same contexts as the original issue, when the assembly is loaded, tries to locate the
en-us
dll and failsTo reproduce
Inspect the produced dll, missing assembly attribute
Expected behavior
Expect the attribute to be there
Further technical details
Microsoft.Data.SqlClient version: 6.x
.NET target: .NET Framework
The text was updated successfully, but these errors were encountered: