Skip to content

NeutralResourcesLanguageAttribute missing #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BradBarnich opened this issue May 1, 2025 · 0 comments
Open

NeutralResourcesLanguageAttribute missing #3324

BradBarnich opened this issue May 1, 2025 · 0 comments
Labels
Triage Needed 🆕 For new issues, not triaged yet.
Milestone

Comments

@BradBarnich
Copy link

Describe the bug

in the 6.x series the NeutralResourcesLanguageAttribute is missing from the netfx assembly (regression of #426)

I think it was after csproj was converted to sdk style in #2413, as the way of overriding BeforeBuild (in GenerateAssemblyInfo.targets) doesn't work with implicit targets (dotnet/msbuild#9327)

You can also see this in the msbuild log:

Overriding target "BeforeBuild" in project "C:\Users\Brad\Code\SqlClient\src\Microsoft.Data.SqlClient\netfx\tools\targets\GenerateAssemblyInfo.targets" with target "BeforeBuild" from project "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets".

In the same contexts as the original issue, when the assembly is loaded, tries to locate the en-us dll and fails

To reproduce

Inspect the produced dll, missing assembly attribute

Expected behavior

Expect the attribute to be there

Further technical details

Microsoft.Data.SqlClient version: 6.x
.NET target: .NET Framework

@cheenamalhotra cheenamalhotra added the Triage Needed 🆕 For new issues, not triaged yet. label May 2, 2025
@cheenamalhotra cheenamalhotra added this to the 6.1-preview2 milestone May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage Needed 🆕 For new issues, not triaged yet.
Projects
None yet
Development

No branches or pull requests

2 participants