Mark obsolete methods to not show up in intellisense (#745)

Author: twsouthwick

CHANGELOG.md

@@ -8,7 +8,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ### Fixed
 - Ensure .NET Framework builds pass PEVerify (#744)
-- DeletePart no longer throws an exception if there isn't a match for the identifier given (#740)
+- `OpenXmlPartContainer.DeletePart` no longer throws an exception if there isn't a match for the identifier given (#740)
+- Mark obsolete members to not show up with Intellisense (#745)
 
 ## Version 2.11.0 - 2020-05-21
 ### Added

src/DocumentFormat.OpenXml/Framework/ChildElementInfoAttribute.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
+using System.ComponentModel;
 
 namespace DocumentFormat.OpenXml
 {
@@ -10,6 +11,7 @@ namespace DocumentFormat.OpenXml
     /// </summary>
     [AttributeUsage(AttributeTargets.Class, Inherited = true, AllowMultiple = true)]
     [Obsolete("This attribute is no longer used and will be removed in a later release")]
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public sealed class ChildElementInfoAttribute : Attribute
     {
         /// <summary>

src/DocumentFormat.OpenXml/Office2013/WebExtension/WebExtension.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
+using System.ComponentModel;
 
 namespace DocumentFormat.OpenXml.Office2013.WebExtension
 {
@@ -12,6 +13,7 @@ public partial class WebExtension
         /// until the next major version change. The <see cref="Frozen"/> property should be used instead.
         /// </summary>
         [Obsolete("Please use the property 'Frozen' as this property will be removed in a future version")]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public BooleanValue Fronzen
         {
             get => Frozen;

src/DocumentFormat.OpenXml/Office2016/Drawing/ChartDrawing/ChartDrawing.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
+using System.ComponentModel;
 
 namespace DocumentFormat.OpenXml.Office2016.Drawing.ChartDrawing
 {
@@ -11,6 +12,7 @@ namespace DocumentFormat.OpenXml.Office2016.Drawing.ChartDrawing
     /// <para>When the object is serialized out as xml, it's qualified name is cx:idx.</para>
     /// </summary>
     [Obsolete("Please use UnsignedIntegerType as this type will be removed in a future version")]
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public partial class IdxXsdunsignedInt : OpenXmlLeafTextElement
     {
         /// <summary>

src/DocumentFormat.OpenXml/Packaging/OpenXmlPackage.cs

@@ -6,6 +6,7 @@
 using DocumentFormat.OpenXml.Validation.Semantic;
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Diagnostics;
 using System.IO;
 using System.IO.Packaging;
@@ -482,6 +483,7 @@ public bool DeletePart(DataPart dataPart)
         /// <param name="validationSettings">The OpenXmlPackageValidationSettings for validation events.</param>
         /// <remarks>If validationSettings is null or no EventHandler is set, the default behavior is to throw an OpenXmlPackageException on the validation error. </remarks>
         [Obsolete(ObsoleteAttributeMessages.ObsoleteV1ValidationFunctionality, false)]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public void Validate(OpenXmlPackageValidationSettings validationSettings)
         {
             ThrowIfObjectDisposed();
@@ -515,6 +517,7 @@ OpenXmlPackageValidationSettings ValidateSettings(OpenXmlPackageValidationSettin
         }
 
         [Obsolete(ObsoleteAttributeMessages.ObsoleteV1ValidationFunctionality, false)]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         internal void Validate(OpenXmlPackageValidationSettings validationSettings, FileFormatVersions fileFormatVersions)
         {
             Debug.Assert(validationSettings != null);

src/DocumentFormat.OpenXml/Packaging/OpenXmlPackageValidationEventArgs.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
+using System.ComponentModel;
 
 namespace DocumentFormat.OpenXml.Packaging
 {
@@ -10,6 +11,7 @@ namespace DocumentFormat.OpenXml.Packaging
     /// </summary>
     [Serializable]
     [Obsolete(ObsoleteAttributeMessages.ObsoleteV1ValidationFunctionality, false)]
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public sealed class OpenXmlPackageValidationEventArgs : EventArgs
     {
         private string _message;

src/DocumentFormat.OpenXml/Packaging/OpenXmlPackageValidationSettings.cs

@@ -2,13 +2,15 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
+using System.ComponentModel;
 
 namespace DocumentFormat.OpenXml.Packaging
 {
     /// <summary>
     /// Specifies event handlers that will handle OpenXmlPackage validation events and the OpenXmlPackageValidationEventArgs.
     /// </summary>
     [Obsolete(ObsoleteAttributeMessages.ObsoleteV1ValidationFunctionality, false)]
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public class OpenXmlPackageValidationSettings
     {
         private EventHandler<OpenXmlPackageValidationEventArgs> valEventHandler;

src/DocumentFormat.OpenXml/Packaging/OpenXmlPart.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Diagnostics;
 using System.IO;
 using System.IO.Packaging;
@@ -397,6 +398,7 @@ public virtual string ContentType
         /// <param name="schemas">The set of XML schemas to be used.</param>
         /// <param name="validationEventHandler">ValidationEventHandler for validation events.</param>
         [Obsolete(ObsoleteAttributeMessages.ObsoleteV1ValidationFunctionality, false)]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public void ValidateXml(XmlSchemaSet schemas, ValidationEventHandler validationEventHandler)
         {
             ThrowIfObjectDisposed();
@@ -441,6 +443,7 @@ public void ValidateXml(XmlSchemaSet schemas, ValidationEventHandler validationE
         /// <param name="schemaFile">The XML schema to be used.</param>
         /// <param name="validationEventHandler">ValidationEventHandler for validation events.</param>
         [Obsolete(ObsoleteAttributeMessages.ObsoleteV1ValidationFunctionality, false)]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public void ValidateXml(string schemaFile, ValidationEventHandler validationEventHandler)
         {
             ThrowIfObjectDisposed();

src/DocumentFormat.OpenXml/Packaging/OpenXmlPartContainer.cs

@@ -5,6 +5,7 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using System.ComponentModel;
 using System.Diagnostics;
 using System.IO.Packaging;
 using System.Linq;
@@ -937,6 +938,7 @@ public void DeleteParts<T>(IEnumerable<T> partsToBeDeleted)
         /// <typeparam name="T">The type of the part.</typeparam>
         /// <returns>The number of parts of this type.</returns>
         [Obsolete("Use GetPartsOfType<T>().Count() instead")]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public int GetPartsCountOfType<T>()
             where T : OpenXmlPart
         {
@@ -1279,6 +1281,7 @@ public IEnumerable<T> GetPartsOfType<T>()
         /// <param name="partCollection">The part collection to be filled in.</param>
         /// <exception cref="ArgumentNullException">Thrown when <paramref name="partCollection"/> is null.</exception>
         [Obsolete("Use GetPartsOfType<T> to manually add to a collection")]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public void GetPartsOfType<T>(ICollection<T> partCollection)
             where T : OpenXmlPart
         {

src/DocumentFormat.OpenXml/XmlPath.cs

@@ -5,6 +5,7 @@
 using DocumentFormat.OpenXml.Packaging;
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Diagnostics;
 using System.Linq;
 using System.Text;
@@ -67,6 +68,7 @@ internal XmlPath(OpenXmlPart part)
         /// Gets the namespace definitions used in <see cref="XPath"/>. Use <see cref="Namespaces"/> instead
         /// </summary>
         [Obsolete("Use the Namespaces property instead")]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public IList<string> NamespacesDefinitions { get; }
 
         /// <summary>