fix source of indeterminism in xaml compiler.

danwalmsley · danwalmsley · commit f31f644916a7 · 2022-05-09T11:02:47.000+01:00
diff --git a/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/XamlIlClrPropertyInfoHelper.cs b/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/XamlIlClrPropertyInfoHelper.cs
@@ -55,7 +55,7 @@ IXamlMethod Get()
                         return cached.get;
                 }
 
-                var name = lst.Count == 0 ? key : key + "_" + Guid.NewGuid().ToString("N");
+                var name = lst.Count == 0 ? key : key + "_" + context.Configuration.IdentifierGenerator.GenerateIdentifierPart();
                 
                 var field = _builder.DefineField(types.IPropertyInfo, name + "!Field", false, true);
 

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ IXamlMethod Get()`
`55`	`55`	`return cached.get;`
`56`	`56`	`}`
`57`	`57`
`58`		`- var name = lst.Count == 0 ? key : key + "_" + Guid.NewGuid().ToString("N");`
	`58`	`+ var name = lst.Count == 0 ? key : key + "_" + context.Configuration.IdentifierGenerator.GenerateIdentifierPart();`
`59`	`59`
`60`	`60`	`var field = _builder.DefineField(types.IPropertyInfo, name + "!Field", false, true);`
`61`	`61`