Skip to content

Feature request: Give user ability to provide a patcher pattern #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arths31 opened this issue Feb 28, 2025 · 2 comments · Fixed by #3036
Closed

Feature request: Give user ability to provide a patcher pattern #2972

arths31 opened this issue Feb 28, 2025 · 2 comments · Fixed by #3036

Comments

@arths31
Copy link

arths31 commented Feb 28, 2025

Hello,

I am wondering if it would be possible to add a property in PatchDocumentOptions so the user could define the pattern used to patch.

For example instead of using {{ }} we could use { } or [ ].

I see that at the moment the pattern is hardcoded in from-docx.ts line 138.
const patchText = {{${patchKey}}};

Tell me your thoughts
Thanks

@arths31
Copy link
Author

arths31 commented Feb 28, 2025

Here is a quick and dirty example : arths31@64961d8

@arths31
Copy link
Author

arths31 commented May 1, 2025

Thank you @dolanmiu @venkateshwarreddyr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant