Add and improve property hook tests.

Author: beberlei

src/Mapping/ClassMetadataFactory.php

@@ -24,7 +24,6 @@
 use Doctrine\Persistence\Mapping\ClassMetadata as ClassMetadataInterface;
 use Doctrine\Persistence\Mapping\Driver\MappingDriver;
 use Doctrine\Persistence\Mapping\ReflectionService;
-use LogicException;
 use ReflectionClass;
 use ReflectionException;
 
@@ -299,14 +298,6 @@ protected function validateRuntimeMetadata(ClassMetadata $class, ClassMetadataIn
             // second condition is necessary for mapped superclasses in the middle of an inheritance hierarchy
             throw MappingException::noInheritanceOnMappedSuperClass($class->name);
         }
-
-        foreach ($class->propertyAccessors as $propertyAccessor) {
-            $property = $propertyAccessor->getUnderlyingReflector();
-
-            if (PHP_VERSION_ID >= 80400 && count($property->getHooks()) > 0) {
-                throw new LogicException('Doctrine ORM does not support property hooks without also enabling Configuration::enableNativeLazyObjects(true). Check https://github.com/doctrine/orm/issues/11624 for details of versions that support property hooks.');
-            }
-        }
     }
 
     protected function newClassMetadataInstance(string $className): ClassMetadata
@@ -710,6 +701,18 @@ private function inheritIdGeneratorMapping(ClassMetadata $class, ClassMetadata $
     protected function wakeupReflection(ClassMetadataInterface $class, ReflectionService $reflService): void
     {
         $class->wakeupReflection($reflService);
+
+        if (PHP_VERSION_ID < 80400) {
+            return;
+        }
+
+        foreach ($class->propertyAccessors as $propertyAccessor) {
+            $property = $propertyAccessor->getUnderlyingReflector();
+
+            if ($property->isVirtual()) {
+                throw MappingException::mappingVirtualPropertyNotAllowed($class->name, $property->getName());
+            }
+        }
     }
 
     protected function initializeReflection(ClassMetadataInterface $class, ReflectionService $reflService): void

src/Mapping/MappingException.php

@@ -688,4 +688,13 @@ public static function invalidAttributeOnEmbeddable(string $entityName, string $
             $entityName,
         ));
     }
+
+    public static function mappingVirtualPropertyNotAllowed(string $entityName, string $propertyName): self
+    {
+        return new self(sprintf(
+            'Mapping virtual property "%s" on entity "%s" is not allowed.',
+            $propertyName,
+            $entityName,
+        ));
+    }
 }

src/Proxy/ProxyFactory.php

@@ -13,6 +13,7 @@
 use Doctrine\ORM\Utility\IdentifierFlattener;
 use Doctrine\Persistence\Mapping\ClassMetadata;
 use Doctrine\Persistence\Proxy;
+use LogicException;
 use ReflectionClass;
 use ReflectionProperty;
 use Symfony\Component\VarExporter\ProxyHelper;

tests/Tests/Models/PropertyHooks/MappingVirtualProperty.php

@@ -0,0 +1,32 @@
+<?php
+// phpcs:ignoreFile
+namespace Doctrine\Tests\Models\PropertyHooks;
+
+use Doctrine\DBAL\Types\Types;
+use Doctrine\ORM\Mapping\Column;
+use Doctrine\ORM\Mapping\Entity;
+use Doctrine\ORM\Mapping\GeneratedValue;
+use Doctrine\ORM\Mapping\Id;
+use Doctrine\ORM\Mapping\Table;
+
+#[Entity]
+#[Table(name: 'property_hooks_user')]
+class MappingVirtualProperty
+{
+    #[Id, GeneratedValue, Column(type: Types::INTEGER)]
+    public ?int $id;
+
+    #[Column(type: Types::STRING)]
+    public string $first;
+
+    #[Column(type: Types::STRING)]
+    public string $last;
+
+    #[Column(type: Types::STRING)]
+    public string $fullName {
+        get => $this->first . " " . $this->last;
+        set {
+            [$this->first, $this->last] = explode(' ', $value, 2);
+        }
+    }
+}

tests/Tests/Models/PropertyHooks/User.php

@@ -37,10 +37,7 @@ class User
     }
 
     public string $fullName {
-        // Override the "read" action with arbitrary logic.
         get => $this->first . " " . $this->last;
-
-        // Override the "write" action with arbitrary logic.
         set {
             [$this->first, $this->last] = explode(' ', $value, 2);
         }

tests/Tests/ORM/Functional/PropertyHooksTest.php

@@ -4,6 +4,8 @@
 
 namespace Doctrine\Tests\ORM\Functional;
 
+use Doctrine\ORM\Mapping\MappingException;
+use Doctrine\Tests\Models\PropertyHooks\MappingVirtualProperty;
 use Doctrine\Tests\Models\PropertyHooks\User;
 use Doctrine\Tests\OrmFunctionalTestCase;
 use PHPUnit\Framework\Attributes\RequiresPhp;
@@ -60,9 +62,27 @@ public function testTriggerLazyLoadingWhenAccessingPropertyHooks(): void
 
         $user = $this->_em->getReference(User::class, $user->id);
 
+        $this->assertTrue($this->_em->getUnitOfWork()->isUninitializedObject($user));
+
         self::assertEquals('Ludwig', $user->first);
         self::assertEquals('von Beethoven', $user->last);
         self::assertEquals('Ludwig von Beethoven', $user->fullName);
         self::assertEquals('DE', $user->language, 'The property hook uppercases the language.');
+
+        $this->assertFalse($this->_em->getUnitOfWork()->isUninitializedObject($user));
+
+        $this->_em->clear();
+
+        $user = $this->_em->getReference(User::class, $user->id);
+
+        self::assertEquals('Ludwig von Beethoven', $user->fullName);
+    }
+
+    public function testMappingVirtualPropertyIsNotSupported(): void
+    {
+        $this->expectException(MappingException::class);
+        $this->expectExceptionMessage('Mapping virtual property "fullName" on entity "Doctrine\Tests\Models\PropertyHooks\MappingVirtualProperty" is not allowed.');
+
+        $this->_em->getClassMetadata(MappingVirtualProperty::class);
     }
 }