Replace spl_object_hash with spl_object_id (#2738)

Author: GromNaN

lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php

@@ -61,7 +61,7 @@
 use function is_object;
 use function is_scalar;
 use function is_string;
-use function spl_object_hash;
+use function spl_object_id;
 use function sprintf;
 use function strpos;
 use function strtolower;
@@ -96,14 +96,14 @@ final class DocumentPersister
     /**
      * Array of queued inserts for the persister to insert.
      *
-     * @var array<string, object>
+     * @var array<int, object>
      */
     private array $queuedInserts = [];
 
     /**
      * Array of queued inserts for the persister to insert.
      *
-     * @var array<string, object>
+     * @var array<int, object>
      */
     private array $queuedUpserts = [];
 
@@ -136,15 +136,15 @@ public function __construct(
         $this->bucket = $dm->getDocumentBucket($class->name);
     }
 
-    /** @return array<string, object> */
+    /** @return array<int, object> */
     public function getInserts(): array
     {
         return $this->queuedInserts;
     }
 
     public function isQueuedForInsert(object $document): bool
     {
-        return isset($this->queuedInserts[spl_object_hash($document)]);
+        return isset($this->queuedInserts[spl_object_id($document)]);
     }
 
     /**
@@ -153,18 +153,18 @@ public function isQueuedForInsert(object $document): bool
      */
     public function addInsert(object $document): void
     {
-        $this->queuedInserts[spl_object_hash($document)] = $document;
+        $this->queuedInserts[spl_object_id($document)] = $document;
     }
 
-    /** @return array<string, object> */
+    /** @return array<int, object> */
     public function getUpserts(): array
     {
         return $this->queuedUpserts;
     }
 
     public function isQueuedForUpsert(object $document): bool
     {
-        return isset($this->queuedUpserts[spl_object_hash($document)]);
+        return isset($this->queuedUpserts[spl_object_id($document)]);
     }
 
     /**
@@ -173,7 +173,7 @@ public function isQueuedForUpsert(object $document): bool
      */
     public function addUpsert(object $document): void
     {
-        $this->queuedUpserts[spl_object_hash($document)] = $document;
+        $this->queuedUpserts[spl_object_id($document)] = $document;
     }
 
     /**

lib/Doctrine/ODM/MongoDB/Repository/AbstractRepositoryFactory.php

@@ -11,7 +11,7 @@
 use Doctrine\Persistence\ObjectRepository;
 
 use function is_a;
-use function spl_object_hash;
+use function spl_object_id;
 
 /**
  * Abstract factory for creating document repositories.
@@ -35,7 +35,7 @@ abstract class AbstractRepositoryFactory implements RepositoryFactory
     public function getRepository(DocumentManager $documentManager, string $documentName): ObjectRepository
     {
         $metadata = $documentManager->getClassMetadata($documentName);
-        $hashKey  = $metadata->getName() . spl_object_hash($documentManager);
+        $hashKey  = $metadata->getName() . '_' . spl_object_id($documentManager);
 
         if (isset($this->repositoryList[$hashKey])) {
             return $this->repositoryList[$hashKey];