Remove handling of non-initialized object names

Author: morozov

src/Schema/AbstractAsset.php

@@ -38,11 +38,6 @@ abstract class AbstractAsset
 {
     protected string $_name = '';
 
-    /**
-     * Indicates whether the object name has been initialized.
-     */
-    protected bool $isNameInitialized = false;
-
     /**
      * Namespace of the asset. If none isset the default namespace is assumed.
      */
@@ -67,8 +62,6 @@ public function __construct(string $name)
 
         $this->setName($parsedName);
 
-        $this->isNameInitialized = true;
-
         if ($parsedName === null) {
             return;
         }

src/Schema/AbstractNamedObject.php

@@ -5,7 +5,6 @@
 namespace Doctrine\DBAL\Schema;
 
 use Doctrine\DBAL\Schema\Exception\InvalidName;
-use Doctrine\DBAL\Schema\Exception\NameIsNotInitialized;
 
 /**
  * An abstract {@see NamedObject}.
@@ -19,9 +18,6 @@ abstract class AbstractNamedObject extends AbstractAsset implements NamedObject
     /**
      * The name of the database object.
      *
-     * Until the validity of the name is enforced, this property isn't guaranteed to be always initialized. The property
-     * can be accessed only if {@see $isNameInitialized} is set to true.
-     *
      * @var N
      */
     protected Name $name;
@@ -35,15 +31,9 @@ public function __construct(string $name)
      * Returns the object name.
      *
      * @return N
-     *
-     * @throws NameIsNotInitialized
      */
     public function getObjectName(): Name
     {
-        if (! $this->isNameInitialized) {
-            throw NameIsNotInitialized::new();
-        }
-
         return $this->name;
     }
 

src/Schema/AbstractOptionallyNamedObject.php

@@ -4,8 +4,6 @@
 
 namespace Doctrine\DBAL\Schema;
 
-use Doctrine\DBAL\Schema\Exception\NameIsNotInitialized;
-
 /**
  * An abstract {@see OptionallyNamedObject}.
  *
@@ -18,9 +16,6 @@ abstract class AbstractOptionallyNamedObject extends AbstractAsset implements Op
     /**
      * The name of the database object.
      *
-     * Until the validity of the name is enforced, this property isn't guaranteed to be always initialized. The property
-     * can be accessed only if {@see $isNameInitialized} is set to true.
-     *
      * @var ?N
      */
     protected ?Name $name;
@@ -32,10 +27,6 @@ public function __construct(?string $name)
 
     public function getObjectName(): ?Name
     {
-        if (! $this->isNameInitialized) {
-            throw NameIsNotInitialized::new();
-        }
-
         return $this->name;
     }
 

src/Schema/Exception/NameIsNotInitialized.php

@@ -5,9 +5,7 @@
 namespace Doctrine\DBAL\Tests\Schema;
 
 use Doctrine\DBAL\Schema\AbstractNamedObject;
-use Doctrine\DBAL\Schema\AbstractOptionallyNamedObject;
 use Doctrine\DBAL\Schema\Exception\InvalidName;
-use Doctrine\DBAL\Schema\Exception\NameIsNotInitialized;
 use Doctrine\DBAL\Schema\Name;
 use Doctrine\Deprecations\PHPUnit\VerifyDeprecations;
 use PHPUnit\Framework\TestCase;
@@ -24,18 +22,4 @@ public function testEmptyName(): void
         class ('') extends AbstractNamedObject {
         };
     }
-
-    public function testAccessToUninitializedName(): void
-    {
-        $object = new /** @extends AbstractOptionallyNamedObject<Name> */
-        class () extends AbstractOptionallyNamedObject {
-            /** @phpstan-ignore constructor.missingParentCall */
-            public function __construct()
-            {
-            }
-        };
-
-        $this->expectException(NameIsNotInitialized::class);
-        $object->getObjectName();
-    }
 }

tests/Schema/AbstractNamedObjectTest.php

@@ -5,7 +5,6 @@
 namespace Doctrine\DBAL\Tests\Schema;
 
 use Doctrine\DBAL\Schema\AbstractOptionallyNamedObject;
-use Doctrine\DBAL\Schema\Exception\NameIsNotInitialized;
 use Doctrine\DBAL\Schema\Name;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
@@ -28,18 +27,4 @@ public static function emptyNameProvider(): iterable
         yield 'empty-string' => [''];
         yield 'empty-null' => [null];
     }
-
-    public function testAccessToUninitializedName(): void
-    {
-        $object = new /** @extends AbstractOptionallyNamedObject<Name> */
-        class () extends AbstractOptionallyNamedObject {
-            /** @phpstan-ignore constructor.missingParentCall */
-            public function __construct()
-            {
-            }
-        };
-
-        $this->expectException(NameIsNotInitialized::class);
-        $object->getObjectName();
-    }
 }