Simplify CustomIntrospectionTest

Author: derrabus

tests/Functional/Schema/CustomIntrospectionTest.php

@@ -4,10 +4,7 @@
 
 namespace Doctrine\DBAL\Tests\Functional\Schema;
 
-use Doctrine\DBAL\Platforms\AbstractMySQLPlatform;
-use Doctrine\DBAL\Platforms\AbstractPlatform;
-use Doctrine\DBAL\Schema\AbstractSchemaManager;
-use Doctrine\DBAL\Schema\Comparator;
+use Doctrine\DBAL\Schema\ColumnDiff;
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\Tests\Functional\Schema\Types\MoneyType;
 use Doctrine\DBAL\Tests\FunctionalTestCase;
@@ -25,32 +22,14 @@
  */
 class CustomIntrospectionTest extends FunctionalTestCase
 {
-    private AbstractSchemaManager $schemaManager;
-
-    private Comparator $comparator;
-
-    private AbstractPlatform $platform;
-
     public static function setUpBeforeClass(): void
     {
         Type::addType('money', MoneyType::class);
     }
 
-    protected function setUp(): void
-    {
-        $this->platform = $this->connection->getDatabasePlatform();
-
-        if (! $this->platform instanceof AbstractMySQLPlatform) {
-            self::markTestSkipped();
-        }
-
-        $this->schemaManager = $this->connection->createSchemaManager();
-        $this->comparator    = $this->schemaManager->createComparator();
-    }
-
     public function testCustomColumnIntrospection(): void
     {
-        $tableName = 'test_custom_column_introspection';
+        $tableName = 'test_custom_column_intro';
         $table     = new Table($tableName);
 
         $table->addColumn('id', 'integer');
@@ -63,18 +42,21 @@ public function testCustomColumnIntrospection(): void
 
         $this->dropAndCreateTable($table);
 
-        $onlineTable = $this->schemaManager->introspectTable($tableName);
-
-        $diff        = $this->comparator->compareTables($table, $onlineTable);
-        $changedCols = [];
+        $schemaManager = $this->connection->createSchemaManager();
+        $onlineTable   = $schemaManager->introspectTable($tableName);
+        $diff          = $schemaManager->createComparator()->compareTables($table, $onlineTable);
+        $changedCols   = array_map(
+            static function (ColumnDiff $columnDiff): ?string {
+                $column = $columnDiff->getOldColumn();
 
-        if (! $diff->isEmpty()) {
-            $changedCols = array_map(static fn ($c) => $c->getOldColumnName()->getName(), $diff->getModifiedColumns());
-        }
+                return $column !== null ? $column->getName() : null;
+            },
+            $diff->getModifiedColumns(),
+        );
 
         self::assertTrue($diff->isEmpty(), sprintf(
             'Tables should be identical. Differences detected in %s.',
-            implode(':', $changedCols),
+            implode(', ', $changedCols),
         ));
     }
 }