Skip to content

Commit e9ede0c

Browse files
authored
Replace TODO with proper PR link (#6195)
| Q | A |------------- | ----------- | Type | bug | Fixed issues | Follows #6193 #### Summary Classic. Usually, @greg0ire finds those things in his review. But not today. 😬
1 parent 29aafaf commit e9ede0c

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

src/Query/QueryBuilder.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1351,7 +1351,7 @@ public function resetQueryParts($queryPartNames = null)
13511351
{
13521352
Deprecation::trigger(
13531353
'doctrine/dbal',
1354-
'TODO',
1354+
'https://github.com/doctrine/dbal/pull/6193',
13551355
'%s() is deprecated, instead use dedicated reset methods for the parts that shall be reset.',
13561356
__METHOD__,
13571357
);
@@ -1381,7 +1381,7 @@ public function resetQueryPart($queryPartName)
13811381
if ($queryPartName === 'distinct') {
13821382
Deprecation::trigger(
13831383
'doctrine/dbal',
1384-
'TODO',
1384+
'https://github.com/doctrine/dbal/pull/6193',
13851385
'Calling %s() with "distinct" is deprecated, call distinct(false) instead.',
13861386
__METHOD__,
13871387
);
@@ -1393,7 +1393,7 @@ public function resetQueryPart($queryPartName)
13931393
if (array_key_exists($queryPartName, self::SQL_PARTS_DEFAULTS) && method_exists($this, $newMethodName)) {
13941394
Deprecation::trigger(
13951395
'doctrine/dbal',
1396-
'TODO',
1396+
'https://github.com/doctrine/dbal/pull/6193',
13971397
'Calling %s() with "%s" is deprecated, call %s() instead.',
13981398
__METHOD__,
13991399
$queryPartName,
@@ -1405,7 +1405,7 @@ public function resetQueryPart($queryPartName)
14051405

14061406
Deprecation::trigger(
14071407
'doctrine/dbal',
1408-
'TODO',
1408+
'https://github.com/doctrine/dbal/pull/6193',
14091409
'Calling %s() with "%s" is deprecated without replacement.',
14101410
__METHOD__,
14111411
$queryPartName,

tests/Query/QueryBuilderTest.php

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ public function testResetQueryParts(): void
627627
{
628628
$qb = $this->prepareQueryBuilderToReset();
629629

630-
$this->expectDeprecationWithIdentifier('TODO');
630+
$this->expectDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
631631
$qb->resetQueryParts(['distinct', 'where', 'orderBy']);
632632

633633
self::assertEquals('SELECT u.* FROM users u', (string) $qb);
@@ -637,7 +637,7 @@ public function testLegacyResetSelect(): void
637637
{
638638
$qb = $this->prepareQueryBuilderToReset();
639639

640-
$this->expectDeprecationWithIdentifier('TODO');
640+
$this->expectDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
641641
$qb->resetQueryPart('select')->addSelect('u.name');
642642

643643
self::assertEquals('SELECT DISTINCT u.name FROM users u WHERE u.name = ? ORDER BY u.name ASC', (string) $qb);
@@ -647,7 +647,7 @@ public function testLegacyResetDistinct(): void
647647
{
648648
$qb = $this->prepareQueryBuilderToReset();
649649

650-
$this->expectDeprecationWithIdentifier('TODO');
650+
$this->expectDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
651651
$qb->resetQueryPart('distinct');
652652

653653
self::assertEquals('SELECT u.* FROM users u WHERE u.name = ? ORDER BY u.name ASC', (string) $qb);
@@ -657,7 +657,7 @@ public function testResetDistinct(): void
657657
{
658658
$qb = $this->prepareQueryBuilderToReset();
659659

660-
$this->expectNoDeprecationWithIdentifier('TODO');
660+
$this->expectNoDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
661661
$qb->distinct(false);
662662

663663
self::assertEquals('SELECT u.* FROM users u WHERE u.name = ? ORDER BY u.name ASC', (string) $qb);
@@ -667,7 +667,7 @@ public function testLegacyResetWhere(): void
667667
{
668668
$qb = $this->prepareQueryBuilderToReset();
669669

670-
$this->expectDeprecationWithIdentifier('TODO');
670+
$this->expectDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
671671
$qb->resetQueryPart('where');
672672

673673
self::assertEquals('SELECT DISTINCT u.* FROM users u ORDER BY u.name ASC', (string) $qb);
@@ -677,7 +677,7 @@ public function testResetWhere(): void
677677
{
678678
$qb = $this->prepareQueryBuilderToReset();
679679

680-
$this->expectNoDeprecationWithIdentifier('TODO');
680+
$this->expectNoDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
681681
$qb->resetWhere();
682682

683683
self::assertEquals('SELECT DISTINCT u.* FROM users u ORDER BY u.name ASC', (string) $qb);
@@ -687,7 +687,7 @@ public function testLegacyResetOrderBy(): void
687687
{
688688
$qb = $this->prepareQueryBuilderToReset();
689689

690-
$this->expectDeprecationWithIdentifier('TODO');
690+
$this->expectDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
691691
$qb->resetQueryPart('orderBy');
692692

693693
self::assertEquals('SELECT DISTINCT u.* FROM users u WHERE u.name = ?', (string) $qb);
@@ -697,7 +697,7 @@ public function testResetOrderBy(): void
697697
{
698698
$qb = $this->prepareQueryBuilderToReset();
699699

700-
$this->expectNoDeprecationWithIdentifier('TODO');
700+
$this->expectNoDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
701701
$qb->resetOrderBy();
702702

703703
self::assertEquals('SELECT DISTINCT u.* FROM users u WHERE u.name = ?', (string) $qb);
@@ -724,7 +724,7 @@ public function testLegacyResetHaving(): void
724724
{
725725
$qb = $this->prepareGroupedQueryBuilderToReset();
726726

727-
$this->expectDeprecationWithIdentifier('TODO');
727+
$this->expectDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
728728
$qb->resetQueryPart('having');
729729

730730
self::assertEquals(
@@ -737,7 +737,7 @@ public function testResetHaving(): void
737737
{
738738
$qb = $this->prepareGroupedQueryBuilderToReset();
739739

740-
$this->expectNoDeprecationWithIdentifier('TODO');
740+
$this->expectNoDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
741741
$qb->resetHaving();
742742

743743
self::assertEquals(
@@ -750,7 +750,7 @@ public function testLegacyResetGroupBy(): void
750750
{
751751
$qb = $this->prepareGroupedQueryBuilderToReset();
752752

753-
$this->expectDeprecationWithIdentifier('TODO');
753+
$this->expectDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
754754
$qb->resetQueryPart('groupBy');
755755

756756
self::assertEquals(
@@ -759,11 +759,11 @@ public function testLegacyResetGroupBy(): void
759759
);
760760
}
761761

762-
public function testGroupBy(): void
762+
public function testResetGroupBy(): void
763763
{
764764
$qb = $this->prepareGroupedQueryBuilderToReset();
765765

766-
$this->expectNoDeprecationWithIdentifier('TODO');
766+
$this->expectNoDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/6193');
767767
$qb->resetGroupBy();
768768

769769
self::assertEquals(

0 commit comments

Comments
 (0)