Merge pull request #6875 from greg0ire/fix-build

Fix build

Author: greg0ire

src/Driver/SQLSrv/Result.php

@@ -106,7 +106,7 @@ public function free(): void
         // @link http://php.net/manual/en/pdostatement.closecursor.php
         // @link https://github.com/php/php-src/blob/php-7.0.11/ext/pdo/pdo_stmt.c#L2075
         // deliberately do not consider multiple result sets, since doctrine/dbal doesn't support them
-        while (sqlsrv_fetch($this->statement)) {
+        while (sqlsrv_fetch($this->statement) === true) {
         }
     }
 

src/Schema/SQLServerSchemaManager.php

@@ -197,7 +197,7 @@ protected function _getPortableTableColumnDefinition($tableColumn)
 
     private function parseDefaultExpression(string $value): ?string
     {
-        while (preg_match('/^\((.*)\)$/s', $value, $matches)) {
+        while (preg_match('/^\((.*)\)$/s', $value, $matches) === 1) {
             $value = $matches[1];
         }
 

tests/Functional/Driver/OCI8/ResultTest.php

@@ -96,7 +96,7 @@ public function testTruncatedFetch(
             $this->createOrReplacePipelinedFunction($expectedTotalRowCount + 10);
         }
 
-        while ($result->fetchOne()) {
+        while ($result->fetchOne() !== false) {
             // Attempt to access all remaining rows from the original fetch
             // The rows locally cached from the default prefetch will first be used
             // but when the result attempts to get the remaining 10 rows beyond

tests/Functional/PortabilityTest.php

@@ -33,15 +33,15 @@ public function testFullFetchMode(): void
 
         $result = $this->connection->executeQuery('SELECT * FROM portability_table');
 
-        while (($row = $result->fetchAssociative())) {
+        while (($row = $result->fetchAssociative()) !== false) {
             $this->assertFetchResultRow($row);
         }
 
         $result = $this->connection
             ->prepare('SELECT * FROM portability_table')
             ->execute();
 
-        while (($row = $result->fetchAssociative())) {
+        while (($row = $result->fetchAssociative()) !== false) {
             $this->assertFetchResultRow($row);
         }
     }

tests/FunctionalTestCase.php

@@ -68,7 +68,7 @@ final protected function disconnect(): void
         // (e.g. to drop a table), and then this reopened connection will remain open and attached to the PHPUnit result
         // until the end of the suite leaking connection resources, while subsequent tests will use
         // the newly established shared connection.
-        unset($this->connection);
+        unset($this->connection); // @phpstan-ignore unset.possiblyHookedProperty
 
         $this->isConnectionReusable = true;
     }