Skip to content

Commit b0ed680

Browse files
committed
Marked some test classes abstract
1. SchemaManagerFunctionalTestCase can be run only via an extending class. Otherwise, it skips all tests. If the test case is represented as an abstract class, PhpStorm will offer a choise of concrete classes which is very handy when debugging test failures. 2. DbalFunctionalTestCase and DbalPerformanceTestCase are meant to be used as base classes and don't contain any tests.
1 parent 29c7ba6 commit b0ed680

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

tests/Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
use function strtolower;
4747
use function substr;
4848

49-
class SchemaManagerFunctionalTestCase extends DbalFunctionalTestCase
49+
abstract class SchemaManagerFunctionalTestCase extends DbalFunctionalTestCase
5050
{
5151
/** @var AbstractSchemaManager */
5252
protected $schemaManager;

tests/Doctrine/Tests/DbalFunctionalTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
use function strpos;
1919
use function var_export;
2020

21-
class DbalFunctionalTestCase extends DbalTestCase
21+
abstract class DbalFunctionalTestCase extends DbalTestCase
2222
{
2323
/**
2424
* Shared connection when a TestCase is run alone (outside of it's functional suite)

tests/Doctrine/Tests/DbalPerformanceTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* and stopTiming at the end of all tests. Tests that do not start or stop
1212
* timing will fail.
1313
*/
14-
class DbalPerformanceTestCase extends DbalFunctionalTestCase
14+
abstract class DbalPerformanceTestCase extends DbalFunctionalTestCase
1515
{
1616
/**
1717
* time the test started

0 commit comments

Comments
 (0)