Merge pull request #6655 from doctrine/4.3.x

Merge 4.3.x up into 5.0.x

Author: morozov

UPGRADE.md

@@ -64,6 +64,10 @@ all drivers and middleware.
 
 # Upgrade to 4.3
 
+## Deprecated `Sequence::isAutoIncrementsFor()`
+
+The `Sequence::isAutoIncrementsFor()` method has been deprecated.
+
 ## Deprecated using invalid database object names
 
 Using the following objects with an empty name is deprecated: `Column`, `View`, `Sequence`, `Identifier`.

psalm.xml.dist

@@ -62,6 +62,12 @@
                 -->
                 <referencedMethod name="Doctrine\DBAL\Schema\AbstractAsset::getNameParser" />
                 <referencedMethod name="Doctrine\DBAL\Schema\AbstractAsset::setName" />
+
+                <!--
+                    https://github.com/doctrine/dbal/pull/6654
+                    TODO: remove in 5.0.0
+                -->
+                <referencedMethod name="Doctrine\DBAL\Schema\Sequence::isAutoIncrementsFor" />
             </errorLevel>
         </DeprecatedMethod>
         <DocblockTypeContradiction>

src/Schema/Sequence.php

@@ -7,6 +7,7 @@
 use Doctrine\DBAL\Schema\Name\OptionallyQualifiedName;
 use Doctrine\DBAL\Schema\Name\Parser\OptionallyQualifiedNameParser;
 use Doctrine\DBAL\Schema\Name\Parsers;
+use Doctrine\Deprecations\Deprecation;
 
 use function count;
 use function sprintf;
@@ -80,9 +81,18 @@ public function setCache(int $cache): self
      *
      * This is used inside the comparator to not report sequences as missing,
      * when the "from" schema implicitly creates the sequences.
+     *
+     * @deprecated
      */
     public function isAutoIncrementsFor(Table $table): bool
     {
+        Deprecation::triggerIfCalledFromOutside(
+            'doctrine/dbal',
+            'https://github.com/doctrine/dbal/pull/6654',
+            '%s is deprecated and will be removed in 5.0.',
+            __METHOD__,
+        );
+
         $primaryKey = $table->getPrimaryKey();
 
         if ($primaryKey === null) {