Deprecate default PostgreSQL connection database

Author: morozov

UPGRADE.md

@@ -8,6 +8,11 @@ awareness about deprecated code.
 
 # Upgrade to 3.5
 
+## Deprecated default PostgreSQL connection database.
+
+Relying on the DBAL connecting to the "postgres" database by default is deprecated. Unless you want to have the server
+determine the default database for the connection, specify the database name explicitly.
+
 ## Deprecated the "default_dbname" parameter of the wrapper `Connection`.
 
 The "default_dbname" parameter of the wrapper `Connection` has been deprecated. Use "dbname" instead.

src/Driver/PDO/PgSQL/Driver.php

@@ -82,9 +82,17 @@ private function constructPdoDsn(array $params): string
 
             $dsn .= 'dbname=' . $params['default_dbname'] . ';';
         } else {
+            if (isset($params['user']) && $params['user'] !== 'postgres') {
+                Deprecation::trigger(
+                    'doctrine/dbal',
+                    'https://github.com/doctrine/dbal/pull/5705',
+                    'Relying on the DBAL connecting to the "postgres" database by default is deprecated.'
+                        . ' Unless you want to have the server determine the default database for the connection,'
+                        . ' specify the database name explicitly.',
+                );
+            }
+
             // Used for temporary connections to allow operations like dropping the database currently connected to.
-            // Connecting without an explicit database does not work, therefore "postgres" database is used
-            // as it is mostly present in every server setup.
             $dsn .= 'dbname=postgres;';
         }