-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typed_fields option to ORM configuration to configure TypedFieldMapper #1779
Conversation
This is a good starting point, but I want to highlight that this doesn't support custom type field mappers. I'm afraid if we did this, in few months someone will complain they can't define custom mapper through configuration. Any suggestions to avoid that? Other than that, this PR is completely missing tests of course. And DefaultTypeFieldMapper service should be defined in orm.xml file. DoctrineExtension will then only reference to it. |
I see your point. This would be the easiest for users to configure, but not the most flexible.
Which then needs to be configured in If that's the preferred way, I can work on that (including tests) |
Let's go with this: For now we don't need support for something else than DefaultTypedFieldMapper. In future if there is a need for custom field mapper, we will add another key (like the one you proposed) and disallow combining it with |
Hi, this issue is open for over a year and is blocking the rest of the Is there a way we could move forwards with it, or maybe move it to |
As can be seen by my comment and PR label, tests are needed to be added |
@tijnema any chance you could work on that soon? @ostrolucky could we move this issue to |
For my current project we don't really need this anymore. |
Indeed, so I guess this is a duplicate! |
This fixes #1696
Configuration syntax is based on the suggestion by @nicolas-grekas here
Love to hear your thoughts, although I'm not an expert in this area.