Skip to content

Commit ff70196

Browse files
committed
Support to retain cache
Signed-off-by: Balaji Arun <[email protected]>
1 parent a946f06 commit ff70196

File tree

7 files changed

+52
-9
lines changed

7 files changed

+52
-9
lines changed

__tests__/context.test.ts

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ describe('getCreateArgs', () => {
3333
['install', 'false'],
3434
['use', 'true'],
3535
['cleanup', 'true'],
36+
['keep-state', 'false']
3637
]),
3738
[
3839
'create',
@@ -50,6 +51,7 @@ describe('getCreateArgs', () => {
5051
['install', 'false'],
5152
['use', 'true'],
5253
['cleanup', 'true'],
54+
['keep-state', 'false']
5355
]),
5456
[
5557
'create',
@@ -67,6 +69,7 @@ describe('getCreateArgs', () => {
6769
['use', 'false'],
6870
['driver-opts', 'image=moby/buildkit:master\nnetwork=host'],
6971
['cleanup', 'true'],
72+
['keep-state', 'false']
7073
]),
7174
[
7275
'create',
@@ -86,6 +89,7 @@ describe('getCreateArgs', () => {
8689
['install', 'false'],
8790
['use', 'true'],
8891
['cleanup', 'true'],
92+
['keep-state', 'false']
8993
]),
9094
[
9195
'create',
@@ -105,6 +109,7 @@ describe('getCreateArgs', () => {
105109
['install', 'false'],
106110
['use', 'true'],
107111
['cleanup', 'true'],
112+
['keep-state', 'false']
108113
]),
109114
[
110115
'create',
@@ -123,6 +128,7 @@ describe('getCreateArgs', () => {
123128
['use', 'false'],
124129
['driver-opts', `"env.no_proxy=localhost,127.0.0.1,.mydomain"`],
125130
['cleanup', 'true'],
131+
['keep-state', 'false'],
126132
]),
127133
[
128134
'create',
@@ -140,6 +146,7 @@ describe('getCreateArgs', () => {
140146
['use', 'false'],
141147
['platforms', 'linux/amd64\n"linux/arm64,linux/arm/v7"'],
142148
['cleanup', 'true'],
149+
['keep-state', 'false'],
143150
]),
144151
[
145152
'create',
@@ -148,7 +155,25 @@ describe('getCreateArgs', () => {
148155
'--buildkitd-flags', '--allow-insecure-entitlement security.insecure --allow-insecure-entitlement network.host',
149156
'--platform', 'linux/amd64,linux/arm64,linux/arm/v7'
150157
]
151-
]
158+
],
159+
[
160+
7,
161+
'v0.10.3',
162+
new Map<string, string>([
163+
['install', 'false'],
164+
['use', 'true'],
165+
['cleanup', 'true'],
166+
['keep-state', 'false'],
167+
['name', 'test-builder-name'],
168+
]),
169+
[
170+
'create',
171+
'--name', 'test-builder-name',
172+
'--driver', 'docker-container',
173+
'--buildkitd-flags', '--allow-insecure-entitlement security.insecure --allow-insecure-entitlement network.host',
174+
'--use'
175+
]
176+
],
152177
])(
153178
'[%d] given buildx %s and %p as inputs, returns %p',
154179
async (num: number, buildxVersion: string, inputs: Map<string, string>, expected: Array<string>) => {
@@ -185,6 +210,7 @@ describe('getAppendArgs', () => {
185210
['install', 'false'],
186211
['use', 'true'],
187212
['cleanup', 'true'],
213+
['keep-state', 'false']
188214
]),
189215
{
190216
"name": "aws_graviton2",

action.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,12 @@ inputs:
4747
cleanup:
4848
description: 'Cleanup temp files and remove builder at the end of a job'
4949
default: 'true'
50+
keep-state:
51+
description: 'Keep state on cleanup'
52+
default: 'false'
53+
required: false
54+
name:
55+
description: 'Builder name use use when creating the builder. If not specified, one will be generated. Specifying a name enables reusing a buildkit volume in persistent self-hosted runners.'
5056
required: false
5157

5258
outputs:

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/context.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,13 @@ export interface Inputs {
2121
configInline: string;
2222
append: string;
2323
cleanup: boolean;
24+
keepState: boolean;
2425
}
2526

2627
export async function getInputs(): Promise<Inputs> {
2728
return {
2829
version: core.getInput('version'),
29-
name: await getBuilderName(core.getInput('driver') || 'docker-container'),
30+
name: getBuilderName(core.getInput('name'), core.getInput('driver') || 'docker-container'),
3031
driver: core.getInput('driver') || 'docker-container',
3132
driverOpts: Util.getInputList('driver-opts', {ignoreComma: true, quote: false}),
3233
buildkitdFlags: core.getInput('buildkitd-flags') || '--allow-insecure-entitlement security.insecure --allow-insecure-entitlement network.host',
@@ -37,12 +38,16 @@ export async function getInputs(): Promise<Inputs> {
3738
config: core.getInput('config'),
3839
configInline: core.getInput('config-inline'),
3940
append: core.getInput('append'),
40-
cleanup: core.getBooleanInput('cleanup')
41+
cleanup: core.getBooleanInput('cleanup'),
42+
keepState: core.getBooleanInput('keep-state')
4143
};
4244
}
4345

44-
export async function getBuilderName(driver: string): Promise<string> {
45-
return driver == 'docker' ? await Docker.context() : `builder-${uuid.v4()}`;
46+
export function getBuilderName(name: string, driver: string): string {
47+
if (name) {
48+
return name;
49+
}
50+
return driver == 'docker' ? 'default' : `builder-${uuid.v4()}`;
4651
}
4752

4853
export async function getCreateArgs(inputs: Inputs, toolkit: Toolkit): Promise<Array<string>> {

src/main.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@ actionsToolkit.run(
6666
fs.mkdirSync(Buildx.certsDir, {recursive: true});
6767
stateHelper.setCertsDir(Buildx.certsDir);
6868

69+
stateHelper.setKeepState(inputs.keepState);
70+
6971
if (inputs.driver !== 'docker') {
7072
await core.group(`Creating a new builder instance`, async () => {
7173
const certsDriverOpts = Buildx.resolveCertsDriverOpts(inputs.driver, inputs.endpoint, {
@@ -176,7 +178,7 @@ actionsToolkit.run(
176178
const buildx = new Buildx({standalone: stateHelper.standalone});
177179
const builder = new Builder({buildx: buildx});
178180
if (await builder.exists(stateHelper.builderName)) {
179-
const rmCmd = await buildx.getCommand(['rm', stateHelper.builderName]);
181+
const rmCmd = await buildx.getCommand(['rm', stateHelper.builderName, stateHelper.keepState ? '--keep-state' : '']);
180182
await exec
181183
.getExecOutput(rmCmd.command, rmCmd.args, {
182184
ignoreReturnCode: true

src/state-helper.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export const builderDriver = process.env['STATE_builderDriver'] || '';
77
export const containerName = process.env['STATE_containerName'] || '';
88
export const certsDir = process.env['STATE_certsDir'] || '';
99
export const cleanup = /true/i.test(process.env['STATE_cleanup'] || '');
10-
10+
export const keepState = !!process.env['STATE_keepState'];
1111
export function setDebug(debug: string) {
1212
core.saveState('isDebug', debug);
1313
}
@@ -35,3 +35,7 @@ export function setCertsDir(certsDir: string) {
3535
export function setCleanup(cleanup: boolean) {
3636
core.saveState('cleanup', cleanup);
3737
}
38+
39+
export function setKeepState(retain: boolean) {
40+
core.saveState('keepState', retain);
41+
}

0 commit comments

Comments
 (0)