Skip to content

Commit c47758b

Browse files
authored
Merge pull request #369 from crazy-max/revert-crypto
switch back to uuid package
2 parents 8026d2b + 8fea382 commit c47758b

File tree

7 files changed

+33
-9
lines changed

7 files changed

+33
-9
lines changed

__tests__/context.test.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import {beforeEach, describe, expect, jest, test} from '@jest/globals';
22
import * as fs from 'fs';
33
import * as path from 'path';
4+
import * as uuid from 'uuid';
45
import {Buildx} from '@docker/actions-toolkit/lib/buildx/buildx';
56
import {Context} from '@docker/actions-toolkit/lib/context';
67
import {Docker} from '@docker/actions-toolkit/lib/docker/docker';
@@ -25,7 +26,8 @@ jest.spyOn(Context, 'tmpName').mockImplementation((): string => {
2526
return tmpName;
2627
});
2728

28-
jest.spyOn(crypto, 'randomUUID').mockReturnValue('9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d');
29+
jest.mock('uuid');
30+
jest.spyOn(uuid, 'v4').mockReturnValue('9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d');
2931

3032
jest.spyOn(Docker, 'context').mockImplementation((): Promise<string> => {
3133
return Promise.resolve('default');

dist/index.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,13 @@
2727
"dependencies": {
2828
"@actions/core": "^1.10.1",
2929
"@docker/actions-toolkit": "^0.39.0",
30-
"js-yaml": "^4.1.0"
30+
"js-yaml": "^4.1.0",
31+
"uuid": "^10.0.0"
3132
},
3233
"devDependencies": {
3334
"@types/js-yaml": "^4.0.9",
3435
"@types/node": "^20.12.12",
36+
"@types/uuid": "^10.0.0",
3537
"@typescript-eslint/eslint-plugin": "^7.9.0",
3638
"@typescript-eslint/parser": "^7.9.0",
3739
"@vercel/ncc": "^0.38.1",

src/context.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import * as uuid from 'uuid';
12
import * as core from '@actions/core';
23

34
import {Docker} from '@docker/actions-toolkit/lib/docker/docker';
@@ -46,7 +47,7 @@ export async function getInputs(): Promise<Inputs> {
4647
}
4748

4849
export async function getBuilderName(driver: string): Promise<string> {
49-
return driver == 'docker' ? await Docker.context() : `builder-${crypto.randomUUID()}`;
50+
return driver == 'docker' ? await Docker.context() : `builder-${uuid.v4()}`;
5051
}
5152

5253
export async function getCreateArgs(inputs: Inputs, toolkit: Toolkit): Promise<Array<string>> {
@@ -83,7 +84,7 @@ export async function getAppendArgs(inputs: Inputs, node: Node, toolkit: Toolkit
8384
if (node.name) {
8485
args.push('--node', node.name);
8586
} else if (inputs.driver == 'kubernetes' && (await toolkit.buildx.versionSatisfies('<0.11.0'))) {
86-
args.push('--node', `node-${crypto.randomUUID()}`);
87+
args.push('--node', `node-${uuid.v4()}`);
8788
}
8889
if (node['driver-opts'] && (await toolkit.buildx.versionSatisfies('>=0.3.0'))) {
8990
await Util.asyncForEach(node['driver-opts'], async (driverOpt: string) => {

src/main.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import * as fs from 'fs';
22
import * as yaml from 'js-yaml';
3+
import * as uuid from 'uuid';
34
import * as core from '@actions/core';
45
import * as actionsToolkit from '@docker/actions-toolkit';
56

@@ -97,7 +98,7 @@ actionsToolkit.run(
9798
});
9899
});
99100
if (defaultContextWithTLS) {
100-
const tmpDockerContext = `buildx-${crypto.randomUUID()}`;
101+
const tmpDockerContext = `buildx-${uuid.v4()}`;
101102
await core.group(`Creating temp docker context (TLS data loaded in default one)`, async () => {
102103
await Docker.getExecOutput(['context', 'create', tmpDockerContext], {
103104
ignoreReturnCode: true

yarn.lock

+18
Original file line numberDiff line numberDiff line change
@@ -2134,6 +2134,13 @@ __metadata:
21342134
languageName: node
21352135
linkType: hard
21362136

2137+
"@types/uuid@npm:^10.0.0":
2138+
version: 10.0.0
2139+
resolution: "@types/uuid@npm:10.0.0"
2140+
checksum: e3958f8b0fe551c86c14431f5940c3470127293280830684154b91dc7eb3514aeb79fe3216968833cf79d4d1c67f580f054b5be2cd562bebf4f728913e73e944
2141+
languageName: node
2142+
linkType: hard
2143+
21372144
"@types/yargs-parser@npm:*":
21382145
version: 20.2.0
21392146
resolution: "@types/yargs-parser@npm:20.2.0"
@@ -3174,6 +3181,7 @@ __metadata:
31743181
"@docker/actions-toolkit": ^0.39.0
31753182
"@types/js-yaml": ^4.0.9
31763183
"@types/node": ^20.12.12
3184+
"@types/uuid": ^10.0.0
31773185
"@typescript-eslint/eslint-plugin": ^7.9.0
31783186
"@typescript-eslint/parser": ^7.9.0
31793187
"@vercel/ncc": ^0.38.1
@@ -3187,6 +3195,7 @@ __metadata:
31873195
ts-jest: ^29.1.2
31883196
ts-node: ^10.9.2
31893197
typescript: ^5.4.5
3198+
uuid: ^10.0.0
31903199
languageName: unknown
31913200
linkType: soft
31923201

@@ -6671,6 +6680,15 @@ __metadata:
66716680
languageName: node
66726681
linkType: hard
66736682

6683+
"uuid@npm:^10.0.0":
6684+
version: 10.0.0
6685+
resolution: "uuid@npm:10.0.0"
6686+
bin:
6687+
uuid: dist/bin/uuid
6688+
checksum: 4b81611ade2885d2313ddd8dc865d93d8dccc13ddf901745edca8f86d99bc46d7a330d678e7532e7ebf93ce616679fb19b2e3568873ac0c14c999032acb25869
6689+
languageName: node
6690+
linkType: hard
6691+
66746692
"uuid@npm:^3.3.2, uuid@npm:^3.3.3":
66756693
version: 3.4.0
66766694
resolution: "uuid@npm:3.4.0"

0 commit comments

Comments
 (0)