Skip to content

Commit e679208

Browse files
committed
Use goproxy to make go mode download work on centos7 (old git version)
Alternative solution was to update git on centos7 in /rpm/SPEC/docker-ce-cli.spec: ``` if [ "$SUITE" == "7" ]; then yum install -y http://opensource.wandisco.com/centos/7/git/x86_64/wandisco-git-release-7-2.noarch.rpm yum install -y git fi ``` But rather not changing what is installed on the CEnTOS bistro for the entire CI pipeline Signed-off-by: Guillaume Tardif <[email protected]>
1 parent 584591b commit e679208

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

plugins/scan.installer

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@ build() {
1717
cd "${DEST}"
1818
git fetch --all
1919
git checkout -q "${COMMIT}"
20-
PLATFORM_BINARY=docker-scan make native-build
20+
# TODO remove GOPROXY override once we updated to Go 1.14+
21+
# Using goproxy instead of "direct" to work around an issue in go mod
22+
# on Go 1.13 not working with older git versions (default version on
23+
# CentOS 7 is git 1.8), see https://github.com/golang/go/issues/38373
24+
GOPROXY="https://proxy.golang.org" PLATFORM_BINARY=docker-scan make native-build
2125
)
2226
}
2327

0 commit comments

Comments
 (0)