Stop throwing exceptions on unrecoverable errors

Author: sisuresh

src/ledger/LedgerManagerImpl.cpp

@@ -1632,7 +1632,7 @@ LedgerManagerImpl::applyThread(AppConnector& app, ThreadEntryMap& entryMap,
     RestoredKeys threadRestoredKeys;
     for (auto const& txBundle : thread)
     {
-        releaseAssertOrThrow(txBundle.getResPayload());
+        releaseAssert(txBundle.getResPayload());
 
         SHA256 txSubSeedSha;
         txSubSeedSha.add(sorobanBasePrngSeed);
@@ -1657,10 +1657,9 @@ LedgerManagerImpl::applyThread(AppConnector& app, ThreadEntryMap& entryMap,
                 auto it = entryMap.find(ttlKey);
                 if (it != entryMap.end())
                 {
-                    releaseAssertOrThrow(it->second.mLedgerEntry);
-                    releaseAssertOrThrow(it->second.mLedgerEntry->data.ttl()
-                                             .liveUntilLedgerSeq <=
-                                         extIt->second);
+                    releaseAssert(it->second.mLedgerEntry);
+                    releaseAssert(it->second.mLedgerEntry->data.ttl()
+                                      .liveUntilLedgerSeq <= extIt->second);
 
                     it->second.mLedgerEntry->data.ttl().liveUntilLedgerSeq =
                         extIt->second;
@@ -1706,16 +1705,16 @@ LedgerManagerImpl::applyThread(AppConnector& app, ThreadEntryMap& entryMap,
                 auto const& updatedLe = entry.second;
 
                 auto it = entryMap.find(lk);
-                releaseAssertOrThrow(it != entryMap.end());
+                releaseAssert(it != entryMap.end());
 
                 auto isReadOnlyTTLIt = isReadOnlyTTLMap.find(lk);
-                releaseAssertOrThrow(lk.type() != TTL ||
-                                     isReadOnlyTTLIt != isReadOnlyTTLMap.end());
+                releaseAssert(lk.type() != TTL ||
+                              isReadOnlyTTLIt != isReadOnlyTTLMap.end());
 
                 if (lk.type() == TTL && it->second.mLedgerEntry && updatedLe &&
                     isReadOnlyTTLIt->second /*isReadOnly*/)
                 {
-                    releaseAssertOrThrow(
+                    releaseAssert(
                         updatedLe->data.ttl().liveUntilLedgerSeq >
                         it->second.mLedgerEntry->data.ttl().liveUntilLedgerSeq);
 
@@ -1743,18 +1742,18 @@ LedgerManagerImpl::applyThread(AppConnector& app, ThreadEntryMap& entryMap,
             for (auto const& key : res.getRestoredKeys().hotArchive)
             {
                 auto [_, inserted] = threadRestoredKeys.hotArchive.emplace(key);
-                releaseAssertOrThrow(inserted);
+                releaseAssert(inserted);
             }
             for (auto const& key : res.getRestoredKeys().liveBucketList)
             {
                 auto [_, inserted] =
                     threadRestoredKeys.liveBucketList.emplace(key);
-                releaseAssertOrThrow(inserted);
+                releaseAssert(inserted);
             }
         }
         else
         {
-            releaseAssertOrThrow(!txBundle.getResPayload()->isSuccess());
+            releaseAssert(!txBundle.getResPayload()->isSuccess());
         }
     }
 

src/transactions/OperationFrame.cpp

@@ -183,7 +183,7 @@ OperationFrame::preloadEntryHelper(
                     auto ttlKey = getTTLKey(lk);
                     auto ttlLtxe = ltx.loadWithoutRecord(ttlKey);
                     // TTL entry must exist
-                    releaseAssertOrThrow(ttlLtxe);
+                    releaseAssert(ttlLtxe);
 
                     entryMap.emplace(ttlKey,
                                      ThreadEntry{ttlLtxe.current(), false});
@@ -198,7 +198,7 @@ OperationFrame::preloadEntryHelper(
                     auto ttlKey = getTTLKey(lk);
                     auto ttlLtxe = ltx.loadWithoutRecord(ttlKey);
                     // TTL entry must not exist
-                    releaseAssertOrThrow(!ttlLtxe);
+                    releaseAssert(!ttlLtxe);
                     entryMap.emplace(ttlKey, ThreadEntry{std::nullopt, false});
                 }
             }

src/transactions/TransactionFrame.cpp

@@ -1703,11 +1703,11 @@ TransactionFrame::preloadEntriesForParallelApply(
     AbstractLedgerTxn& ltx, ThreadEntryMap& entryMap,
     MutableTxResultPtr txResult) const
 {
-    releaseAssertOrThrow(isSoroban());
-    releaseAssertOrThrow(mOperations.size() == 1);
+    releaseAssert(isSoroban());
+    releaseAssert(mOperations.size() == 1);
 
     auto sorobanData = txResult->getSorobanData();
-    releaseAssertOrThrow(sorobanData);
+    releaseAssert(sorobanData);
 
     auto op = mOperations.front();
     auto& opResult = txResult->getOpResultAt(0);
@@ -1830,7 +1830,9 @@ TransactionFrame::parallelApply(
             ledgerInfo.getLedgerVersion() >=
             config.LEDGER_PROTOCOL_MIN_VERSION_INTERNAL_ERROR_REPORT;
 
-        releaseAssertOrThrow(txResult);
+        // We can't set an internal error if this is missing, which is why this
+        // aborts instead of throwing.
+        releaseAssert(txResult);
 
         // This tx failed validation earlier, do not apply it
         if (!txResult->isSuccess())