Merge pull request #88 from dlants/dlants-thread-titles

thread titles

Author: dlants

node/chat/chat.spec.ts

@@ -28,7 +28,7 @@ describe("node/chat/chat.spec.ts", () => {
       );
 
       await driver.magenta.command("new-thread");
-      await driver.assertDisplayBufferContent(LOGO + "\n");
+      await driver.assertDisplayBufferContent("# [ Untitled ]\n" + LOGO + "\n");
     });
   });
 
@@ -47,10 +47,11 @@ describe("node/chat/chat.spec.ts", () => {
       await driver.assertDisplayBufferContains(`\
 # Threads
 
-- 1
-* 2`);
+- 1 [Untitled]
+* 2 [Untitled]`);
 
-      const threadPos = await driver.assertDisplayBufferContains("1");
+      const threadPos =
+        await driver.assertDisplayBufferContains("1 [Untitled]");
       await driver.triggerDisplayBufferKey(threadPos, "<CR>");
       await driver.awaitChatState({
         state: "thread-selected",

node/chat/chat.ts

@@ -238,9 +238,10 @@ export class Chat {
           case "pending":
             status = `${marker} ${id} - loading...\n`;
             break;
-          case "initialized":
-            status = `${marker} ${id}\n`;
+          case "initialized": {
+            status = `${marker} ${id} ${threadState.thread.state.title ?? "[Untitled]"}\n`;
             break;
+          }
           case "error":
             status = `${marker} ${id} - error: ${threadState.error.message}\n`;
             break;

node/chat/thread.ts

@@ -30,6 +30,10 @@ import { type MagentaOptions, type Profile } from "../options.ts";
 import type { RootMsg } from "../root-msg.ts";
 import type { UnresolvedFilePath } from "../utils/files.ts";
 import type { BufferTracker } from "../buffer-tracker.ts";
+import {
+  type Input as ThreadTitleInput,
+  spec as threadTitleToolSpec,
+} from "../tools/thread-title.ts";
 
 export type Role = "user" | "assistant";
 
@@ -51,6 +55,7 @@ export type ConversationState =
     };
 
 export type Msg =
+  | { type: "set-title"; title: string }
   | { type: "update-profile"; profile: Profile }
   | {
       type: "stream-event";
@@ -103,6 +108,7 @@ export type ThreadId = number & { __threadId: true };
 
 export class Thread {
   public state: {
+    title?: string | undefined;
     lastUserMessageId: MessageId;
     profile: Profile;
     conversation: ConversationState;
@@ -244,6 +250,13 @@ export class Thread {
           this.sendMessage(msg.content).catch(
             this.handleSendMessageError.bind(this),
           );
+          if (!this.state.title) {
+            this.setThreadTitle(msg.content).catch((err: Error) =>
+              this.context.nvim.logger?.error(
+                "Error getting thread title: " + err.message + "\n" + err.stack,
+              ),
+            );
+          }
         });
         break;
       }
@@ -375,6 +388,11 @@ export class Thread {
         return;
       }
 
+      case "set-title": {
+        this.state.title = msg.title;
+        return;
+      }
+
       default:
         assertUnreachable(msg);
     }
@@ -565,20 +583,56 @@ export class Thread {
 
     return messages.map((m) => m.message);
   }
+
+  async setThreadTitle(userMessage: string) {
+    const request = getProvider(
+      this.context.nvim,
+      this.context.profile,
+    ).forceToolUse(
+      [
+        {
+          role: "user",
+          content: [
+            {
+              type: "text",
+              text: `\
+The user has provided the following prompt:
+${userMessage}
+
+Come up with a succinct thread title for this prompt. It should be less than 80 characters long.
+`,
+            },
+          ],
+        },
+      ],
+      threadTitleToolSpec,
+    );
+    const result = await request.promise;
+    if (result.toolRequest.status == "ok") {
+      this.myDispatch({
+        type: "set-title",
+        title: (result.toolRequest.value.input as ThreadTitleInput).title,
+      });
+    }
+  }
 }
 
 export const view: View<{
   thread: Thread;
   dispatch: Dispatch<Msg>;
 }> = ({ thread }) => {
+  const titleView = thread.state.title
+    ? d`# ${thread.state.title}`
+    : d`# [ Untitled ]`;
+
   if (
     thread.state.messages.length == 0 &&
     thread.state.conversation.state == "stopped"
   ) {
-    return d`${LOGO}\n${thread.context.contextManager.view()}`;
+    return d`${titleView}\n${LOGO}\n${thread.context.contextManager.view()}`;
   }
 
-  return d`${thread.state.messages.map((m) => d`${m.view()}\n`)}${
+  return d`${titleView}\n${thread.state.messages.map((m) => d`${m.view()}\n`)}${
     thread.state.conversation.state == "message-in-flight"
       ? d`Awaiting response ${
           MESSAGE_ANIMATION[

node/magenta.spec.ts

@@ -18,18 +18,16 @@ describe("node/magenta.spec.ts", () => {
         toolRequests: [],
       });
 
-      await driver.assertDisplayBufferContent(`\
-# user:
+      await driver.assertDisplayBufferContains(`# user:
 hello
 
 # assistant:
 sup?
 
-Stopped (end_turn) [input: 0, output: 0]
-`);
+Stopped (end_turn) [input: 0, output: 0]`);
 
       await driver.clear();
-      await driver.assertDisplayBufferContent(LOGO + "\n");
+      await driver.assertDisplayBufferContains(LOGO);
       await driver.inputMagentaText(`hello again`);
       await driver.send();
       await driver.mockAnthropic.respond({
@@ -38,15 +36,13 @@ Stopped (end_turn) [input: 0, output: 0]
         toolRequests: [],
       });
 
-      await driver.assertDisplayBufferContent(`\
-# user:
+      await driver.assertDisplayBufferContains(`# user:
 hello again
 
 # assistant:
 huh?
 
-Stopped (end_turn) [input: 0, output: 0]
-`);
+Stopped (end_turn) [input: 0, output: 0]`);
     });
   });
 
@@ -55,8 +51,7 @@ Stopped (end_turn) [input: 0, output: 0]
       await driver.showSidebar();
       await driver.inputMagentaText(`hello`);
       await driver.send();
-      await driver.assertDisplayBufferContent(`\
-# user:
+      await driver.assertDisplayBufferContains(`# user:
 hello
 
 Awaiting response ⠁`);

node/tools/helpers.ts

@@ -9,6 +9,7 @@ import * as Diagnostics from "./diagnostics";
 import * as BashCommand from "./bashCommand";
 import * as ReplaceSelection from "./replace-selection-tool";
 import * as InlineEdit from "./inline-edit-tool";
+import * as ThreadTitle from "./thread-title";
 import type { StreamingBlock } from "../providers/helpers";
 import { d, type VDOMNode } from "../tea/view";
 
@@ -39,6 +40,8 @@ export function validateInput(
       return InlineEdit.validateInput(input);
     case "replace_selection":
       return ReplaceSelection.validateInput(input);
+    case "thread_title":
+      return ThreadTitle.validateInput(input);
     default:
       throw new Error(`Unexpected toolName: ${toolName as string}`);
   }

node/tools/thread-title.spec.ts

@@ -0,0 +1,68 @@
+import { describe, expect, it } from "vitest";
+import { withDriver } from "../test/preamble";
+import type { ToolRequestId } from "./toolManager";
+
+describe("node/tools/thread-title.spec.ts", () => {
+  it("sets thread title after user message", async () => {
+    await withDriver({}, async (driver) => {
+      // 1. Open the sidebar
+      await driver.showSidebar();
+
+      // Verify initial state shows untitled
+      await driver.assertDisplayBufferContains("# [ Untitled ]");
+
+      // 2. Send a message
+      const userMessage = "Tell me about the solar system";
+      await driver.inputMagentaText(userMessage);
+      await driver.send();
+
+      // 3. Verify the forceToolUse request was made for thread_title
+      const request =
+        await driver.mockAnthropic.awaitPendingForceToolUseRequest();
+
+      // Verify the request contains the user message
+      expect(request.messages).toMatchObject([
+        {
+          role: "user",
+          content: [
+            {
+              type: "text",
+              // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+              text: expect.stringContaining(userMessage),
+            },
+          ],
+        },
+      ]);
+
+      // 4. Respond to the tool use request with a title
+      const title = "Exploring the Solar System";
+      await driver.mockAnthropic.respondToForceToolUse({
+        stopReason: "end_turn",
+        toolRequest: {
+          status: "ok",
+          value: {
+            id: "id" as ToolRequestId,
+            toolName: "thread_title",
+            input: {
+              title,
+            },
+          },
+        },
+      });
+
+      // 5. Verify the thread title was updated in the display buffer
+      await driver.assertDisplayBufferContains(`# ${title}`);
+
+      // Respond to the original user message
+      await driver.mockAnthropic.streamText(
+        "The solar system consists of the Sun and everything that orbits around it.",
+      );
+
+      // Verify both the title and message are displayed
+      await driver.assertDisplayBufferContains(`# ${title}`);
+      await driver.assertDisplayBufferContains(
+        "The solar system consists of the Sun and everything that orbits around it.",
+      );
+    });
+  });
+});