Skip to content

Rename --colors to --color before next release? #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nordlow opened this issue Aug 17, 2022 · 4 comments · Fixed by #2399
Closed

Rename --colors to --color before next release? #2398

nordlow opened this issue Aug 17, 2022 · 4 comments · Fixed by #2399

Comments

@nordlow
Copy link
Contributor

nordlow commented Aug 17, 2022 •
edited
Loading

At #2268, what is the reason for picking the naming --colors instead of --color?

IRC, --color is more established naming in other (GNU) CLI tools such as ls and grep.

Ping, @kinke @Geod24 @veelo.
@nordlow nordlow changed the title Rename --colors to --color Rename --colors to --color? Aug 17, 2022
@nordlow nordlow changed the title Rename --colors to --color? Rename --colors to --color before next release? Aug 17, 2022
@Geod24
Copy link
Member

Geod24 commented Aug 17, 2022

That's a good point. I'd be in favor of the rename. CC @WebFreak001 .

@veelo
Copy link
Contributor

veelo commented Aug 18, 2022

Indeed, it should be --color.

@WebFreak001
Copy link
Member

sure, sounds good

@nordlow
Copy link
Contributor Author

nordlow commented Aug 18, 2022

See #2399.

@nordlow nordlow mentioned this issue Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename CLI flag --colors to --color any D code symbols accordingly nordlow/dub
4 participants
@nordlow @WebFreak001 @Geod24 @veelo