Expensify#4517 avoid init check race conditions

Author: dklymenk

src/libs/Navigation/AppNavigator/AuthScreens.js

@@ -64,7 +64,6 @@ import WorkspaceSettingsDrawerNavigator from './WorkspaceSettingsDrawerNavigator
 import spacing from '../../../styles/utilities/spacing';
 import CardOverlay from '../../../components/CardOverlay';
 import defaultScreenOptions from './defaultScreenOptions';
-import DateUtils from '../../DateUtils';
 
 const RootStack = createCustomModalStackNavigator();
 
@@ -180,9 +179,6 @@ class AuthScreens extends React.Component {
         this.unsubscribeGroupShortcut = KeyboardShortcut.subscribe('K', () => {
             Navigation.navigate(ROUTES.NEW_GROUP);
         }, groupShortcutModifiers, true);
-        setTimeout(() => {
-            DateUtils.updateTimezone();
-        }, 1000);
     }
 
     shouldComponentUpdate(nextProps) {

src/libs/actions/PersonalDetails.js

@@ -3,6 +3,7 @@ import lodashGet from 'lodash/get';
 import lodashMerge from 'lodash/merge';
 import Onyx from 'react-native-onyx';
 import Str from 'expensify-common/lib/str';
+import moment from 'moment';
 import ONYXKEYS from '../../ONYXKEYS';
 import CONST from '../../CONST';
 import NetworkConnection from '../NetworkConnection';
@@ -93,6 +94,38 @@ function formatPersonalDetails(personalDetailsList) {
     }, {});
 }
 
+/**
+ * Merges partial details object into the local store.
+ *
+ * @param {Object} details
+ * @private
+ */
+function mergeLocalPersonalDetails(details) {
+    // We are merging the partial details provided to this method with the existing details we have for the user so
+    // that we don't overwrite any values that may exist in storage.
+    const mergedDetails = lodashMerge(personalDetails[currentUserEmail], details);
+
+    // displayName is a generated field so we'll use the firstName and lastName + login to update it.
+    mergedDetails.displayName = getDisplayName(currentUserEmail, mergedDetails);
+
+    // Update the associated Onyx keys
+    Onyx.merge(ONYXKEYS.MY_PERSONAL_DETAILS, mergedDetails);
+    Onyx.merge(ONYXKEYS.PERSONAL_DETAILS, {[currentUserEmail]: mergedDetails});
+}
+
+/**
+ * Sets the personal details object for the current user
+ *
+ * @param {Object} details
+ */
+function setPersonalDetails(details) {
+    API.PersonalDetails_Update({details: JSON.stringify(details)});
+    if (details.timezone) {
+        NameValuePair.set(CONST.NVP.TIMEZONE, details.timezone);
+    }
+    mergeLocalPersonalDetails(details);
+}
+
 /**
  * Get the personal details for our organization
  * @returns {Promise}
@@ -120,6 +153,14 @@ function fetchPersonalDetails() {
             myPersonalDetails.firstName = lodashGet(data.personalDetailsList, [currentUserEmail, 'firstName'], '');
             myPersonalDetails.lastName = lodashGet(data.personalDetailsList, [currentUserEmail, 'lastName'], '');
 
+
+            // Update user's timezone, if their timezone is set to automatic and
+            // is different from current timezone
+            const currentTimezone = moment.tz.guess(true);
+            if (myPersonalDetails.timezone.automatic && myPersonalDetails.timezone.selected !== currentTimezone) {
+                myPersonalDetails.timezone.selected = currentTimezone;
+            }
+
             // Set my personal details so they can be easily accessed and subscribed to on their own key
             Onyx.merge(ONYXKEYS.MY_PERSONAL_DETAILS, myPersonalDetails);
         })
@@ -187,38 +228,6 @@ function getFromReportParticipants(reports) {
         });
 }
 
-/**
- * Merges partial details object into the local store.
- *
- * @param {Object} details
- * @private
- */
-function mergeLocalPersonalDetails(details) {
-    // We are merging the partial details provided to this method with the existing details we have for the user so
-    // that we don't overwrite any values that may exist in storage.
-    const mergedDetails = lodashMerge(personalDetails[currentUserEmail], details);
-
-    // displayName is a generated field so we'll use the firstName and lastName + login to update it.
-    mergedDetails.displayName = getDisplayName(currentUserEmail, mergedDetails);
-
-    // Update the associated Onyx keys
-    Onyx.merge(ONYXKEYS.MY_PERSONAL_DETAILS, mergedDetails);
-    Onyx.merge(ONYXKEYS.PERSONAL_DETAILS, {[currentUserEmail]: mergedDetails});
-}
-
-/**
- * Sets the personal details object for the current user
- *
- * @param {Object} details
- */
-function setPersonalDetails(details) {
-    API.PersonalDetails_Update({details: JSON.stringify(details)});
-    if (details.timezone) {
-        NameValuePair.set(CONST.NVP.TIMEZONE, details.timezone);
-    }
-    mergeLocalPersonalDetails(details);
-}
-
 /**
  * Sets the onyx with the currency list from the network
  * @returns {Object}