-
-
Notifications
You must be signed in to change notification settings - Fork 993
Improve 404 page #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
like this? however i don't thinks what i did is a proper way of doing it, i used same search as in documentation page by making some changes in
and in
A more proper way would be writing a handler for 404? but maybe i should ask permission for it before |
@adamchainz I would like to contribute on this issue. |
…ealing design. - Increased the prominence of the "404" header using a mixture of Black (#2b3137) and Green (#2dba4e) colors. - Styled the search bar to resemble GitHub's design with clear input and button elements. - Removed the default value from the search box for a cleaner user experience. Closes: django#1347
fixed by #1454 |
hi i ma new to this project i want to contribute in this project for this problem . Can anyone pls tell me how can i get in contact with the devs |
Hi and thanks for offering to contribute! 🎸 The file is there: https://github.com/django/djangoproject.com/blob/main/djangoproject/templates/404.html For reference, I found it using this command: |
Hi and thanks for your time. i was setting up the environment by using docker but faced the same error though i followed the documentation . |
Improved 404 page, added a search bar, fixed the font on the 404 page.
Hi! I would love to contribute to this project! Is this issue still prevalent? |
I realize only now that we have a fundamental UX problem that could be blocking. I believe that the 404 template is used for all 404 errors both on the site (https://www.djangoproject.com) and in the documentation (https://docs.djangoproject.com). The search is only present in the documentation subdomain, so whoever were to view the 404 page in the domain (https://www.djangoproject.com) would see a search that is actually from the domain (https://docs.djangoproject.com). The solutions proposed so far therefore I do not think are mergiable. I see two alternatives:
|
Cool, I will try out the first alternative. |
Hi! 👋 I'd love to contribute to this issue. Based on the discussion, it seems like a separate 404 template for the documentation site would be a good approach. I'll share updates soon. |
Take a broken docs link like: https://docs.djangoproject.com/en/4.2/ref/databasess/ (two "s" chars at the end instead of one).
The 404 page could at least show the docs search bar to make it easy to search for the relevant page.
For bonus points, it could even show search results for the keywords in the URL ("databasess") or show close matches from existing URL's (using e.g. difflib.get_close_matches).
The text was updated successfully, but these errors were encountered: