Skip to content

Commit 50abe19

Browse files
committed
Removed some lodash functions
+ Fixed little bug with undefined each function
1 parent fd2b864 commit 50abe19

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

lib/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ class BundleTrackerPlugin {
165165

166166
/** @type {Contents} */
167167
const output = { status: 'done', assets: {}, chunks: {} };
168-
each(stats.compilation.assets, (file, assetName) => {
168+
Object.entries(stats.compilation.assets).map(([_, assetName]) => {
169169
const fileInfo = {
170170
name: assetName,
171171
path: getAssetPath(stats.compilation, assetName),

tests/base.test.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
'use strict';
33

44
const fs = require('fs');
5-
const toPairs = require('lodash.topairs');
65
const zlib = require('zlib');
76
const path = require('path');
87
const rimraf = require('rimraf');
@@ -761,8 +760,8 @@ describe('BundleTrackerPlugin bases tests', () => {
761760
() => {
762761
const statsStr = fs.readFileSync(path.join(OUTPUT_DIR, 'webpack-stats.json'), 'utf8');
763762
const stats = JSON.parse(statsStr);
764-
const assetsKeys = toPairs(stats.assets).map(pair => pair[0]);
765-
const chunksKeys = toPairs(stats.chunks).map(pair => pair[0]);
763+
const assetsKeys = Object.entries(stats.assets).map(pair => pair[0]);
764+
const chunksKeys = Object.entries(stats.chunks).map(pair => pair[0]);
766765

767766
expect(assetsKeys).toEqual(['css/appA.css', 'js/1.js', 'js/appA.js', 'js/appZ.js', 'js/commons.js']);
768767
expect(chunksKeys).toEqual(['appA', 'appZ']);

tests/fixtures/commons.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
'use strict';
22

3-
const assign = require('lodash.assign');
4-
53
const output = { name: '' };
64

7-
assign(output, { name: 'common' });
5+
Object.assign({}, output, { name: 'common' });
86

97
module.exports = output;

tests/webpack5.test.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
'use strict';
33

44
const fs = require('fs');
5-
const toPairs = require('lodash.topairs');
65
const zlib = require('zlib');
76
const path = require('path');
87
const rimraf = require('rimraf');
@@ -807,8 +806,8 @@ describe('BundleTrackerPlugin bases tests', () => {
807806
() => {
808807
const statsStr = fs.readFileSync(path.join(OUTPUT_DIR, 'webpack-stats.json'), 'utf8');
809808
const stats = JSON.parse(statsStr);
810-
const assetsKeys = toPairs(stats.assets).map(pair => pair[0]);
811-
const chunksKeys = toPairs(stats.chunks).map(pair => pair[0]);
809+
const assetsKeys = Object.entries(stats.assets).map(pair => pair[0]);
810+
const chunksKeys = Object.entries(stats.chunks).map(pair => pair[0]);
812811

813812
expect(assetsKeys).toEqual(['css/appA.css', 'js/75.js', 'js/appA.js', 'js/appZ.js', 'js/commons.js']);
814813
expect(chunksKeys).toEqual(['appA', 'appZ']);

0 commit comments

Comments
 (0)