Skip to content

Commit 4d86cf4

Browse files
authored
fix(PermissionOverwriteManager): mutates user (#8282)
Fix PermissionOverwriteManager changing userOrRole Since it's mutated the original Member object won't be passed to upset and will be seen as invalid if User cache is disabled. Functions normally even with User cache disabled after the fix.
1 parent beb3d8e commit 4d86cf4

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/managers/PermissionOverwriteManager.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,9 @@ class PermissionOverwriteManager extends CachedManager {
142142
* .catch(console.error);
143143
*/
144144
edit(userOrRole, options, overwriteOptions) {
145-
userOrRole = this.channel.guild.roles.resolveId(userOrRole) ?? this.client.users.resolveId(userOrRole);
146-
const existing = this.cache.get(userOrRole);
145+
const existing = this.cache.get(
146+
this.channel.guild.roles.resolveId(userOrRole) ?? this.client.users.resolveId(userOrRole),
147+
);
147148
return this.upsert(userOrRole, options, overwriteOptions, existing);
148149
}
149150

0 commit comments

Comments
 (0)