Skip to content

Commit 42cd0ab

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request kubernetes#50031 from verult/ConnectedProbe
Automatic merge from submit-queue (batch tested with PRs 51054, 51101, 50031, 51296, 51173) Dynamic Flexvolume plugin discovery, probing with filesystem watch. **What this PR does / why we need it**: Enables dynamic Flexvolume plugin discovery. This model uses a filesystem watch (fsnotify library), which notifies the system that a probe is necessary only if something changes in the Flexvolume plugin directory. This PR uses the dependency injection model in kubernetes#49668. **Release Note**: ```release-note Dynamic Flexvolume plugin discovery. Flexvolume plugins can now be discovered on the fly rather than only at system initialization time. ``` /sig-storage /assign @jsafrane @saad-ali /cc @bassam @chakri-nelluri @kokhang @liggitt @thockin
2 parents cd79a8e + 9ded48d commit 42cd0ab

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/volume/cinder/cinder_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func TestCanSupport(t *testing.T) {
3838
}
3939
defer os.RemoveAll(tmpDir)
4040
plugMgr := volume.VolumePluginMgr{}
41-
plugMgr.InitPlugins(ProbeVolumePlugins(), volumetest.NewFakeVolumeHost(tmpDir, nil, nil))
41+
plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(tmpDir, nil, nil))
4242

4343
plug, err := plugMgr.FindPluginByName("kubernetes.io/cinder")
4444
if err != nil {
@@ -134,7 +134,7 @@ func TestPlugin(t *testing.T) {
134134
}
135135
defer os.RemoveAll(tmpDir)
136136
plugMgr := volume.VolumePluginMgr{}
137-
plugMgr.InitPlugins(ProbeVolumePlugins(), volumetest.NewFakeVolumeHost(tmpDir, nil, nil))
137+
plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(tmpDir, nil, nil))
138138

139139
plug, err := plugMgr.FindPluginByName("kubernetes.io/cinder")
140140
if err != nil {

0 commit comments

Comments
 (0)