Fix rapier(x)d-simd-compat to use simd instructions #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe |
|
I confirm the artifact here fixes. |
Thanks for your attention, I'll probably add a verification step in CI, then discuss it with @sebcrozet before we make a new release containing the fix, in the meantime I hope this updated artifact can be useful. |
|
I'll use my personal build anyway mdrrrr |
Vrixyz
commented
Mar 25, 2025
| @@ -41,4 +41,10 @@ fi | |||
|
|
|||
| # Working dir in wasm-pack is the project root so we need that "../../" | |||
|
|
|||
| wasm-pack build --target web --out-dir "../../rapier-compat/builds/${dimension}d${feature_postfix}/wasm-build" "$rust_source_directory" | |||
| if [[ $feature == "simd" ]]; then | |||
| export additional_rustflags='-C target-feature=+simd128' | |||
There was a problem hiding this comment.
I tried export RUSTFLAGS=[...] but this didn't work (wasn't used by wasm-pack), I think my shell expertise is needing an update, there's probably a slightly cleaner way to achieve this.
in the meantime just removing the export in the only self-improvement I can come up with.
Vrixyz
changed the title
Vrixyz
changed the title
Vrixyz
force-pushed
the
fix_simd_builds
branch
6 times, most recently
from
7b24c1a to
96f4ca3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rapier2d-simd-compat doesn't really use simd128 instruction #314
run
cargo cleanto avoid reusing previously compiled crate ; while this doesn't help much with linked issue, I believe that's a sensible thing to do which will avoid surprises in the long run, so I'd argue to keep it, we're not benefitting much from incremental compilation speed if it comes at a price of sneaky build differences.add simd rustflags when building rapier-compat simd -> that's the real fix.
TODO: add a CI check ; to avoid regressions