Skip to content

Commit da42754

Browse files
author
Timo Reimann
committed
Use WARN log level for non-critical failures to get an action
Action failures are a common source and good indicator for certain CSI-related issues. Logging them at the WARN level makes it easier to identify problems when analyzing logs.
1 parent 8008b09 commit da42754

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
## unreleased
22

3+
* Use WARN log level for non-critical failures to get an action
4+
[[GH-TBD]](https://github.com/digitalocean/csi-digitalocean/pull/TBD)
35
* Reject requests for block access type
46
[[GH-225]](https://github.com/digitalocean/csi-digitalocean/pull/225)
57
* Assume detached state on 404 during ControllerUnpublishVolume

driver/controller.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -966,7 +966,7 @@ func (d *Driver) waitAction(ctx context.Context, volumeId string, actionId int)
966966
if err != nil {
967967
ctxCanceled := ctx.Err() != nil
968968
if !ctxCanceled {
969-
ll.WithError(err).Info("getting action for volume")
969+
ll.WithError(err).Warn("getting action for volume")
970970
return false, nil
971971
}
972972

0 commit comments

Comments
 (0)