Skip to content

Commit 7f5ac7a

Browse files
committed
Fixing b0rken runtimeconfig unit tests.
Broken by simultaneous merges of googleapis#2594 and googleapis#2485.
1 parent 25f4475 commit 7f5ac7a

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

runtimeconfig/unit_tests/test_config.py

+10-6
Original file line numberDiff line numberDiff line change
@@ -208,13 +208,15 @@ def test_get_variable_w_alternate_client(self):
208208
self.assertEqual(req['path'], '/%s' % (VARIABLE_PATH,))
209209

210210
def test_list_variables_empty(self):
211+
import six
212+
211213
conn = _Connection({})
212214
client = _Client(project=self.PROJECT, connection=conn)
213215
config = self._makeOne(name=self.CONFIG_NAME, client=client)
214216

215217
iterator = config.list_variables()
216-
iterator.update_page()
217-
variables = list(iterator.page)
218+
page = six.next(iterator.pages)
219+
variables = list(page)
218220
token = iterator.next_page_token
219221

220222
self.assertEqual(variables, [])
@@ -227,6 +229,7 @@ def test_list_variables_empty(self):
227229
self.assertEqual(req['path'], '/%s' % (PATH,))
228230

229231
def test_list_variables_defaults(self):
232+
import six
230233
from google.cloud.runtimeconfig.variable import Variable
231234

232235
VARIABLE_1 = 'variable-one'
@@ -249,8 +252,8 @@ def test_list_variables_defaults(self):
249252
config = self._makeOne(name=self.CONFIG_NAME, client=client)
250253

251254
iterator = config.list_variables()
252-
iterator.update_page()
253-
variables = list(iterator.page)
255+
page = six.next(iterator.pages)
256+
variables = list(page)
254257
token = iterator.next_page_token
255258

256259
self.assertEqual(len(variables), len(DATA['variables']))
@@ -269,6 +272,7 @@ def test_list_variables_defaults(self):
269272
self.assertNotIn('filter', req['query_params'])
270273

271274
def test_list_variables_explicit(self):
275+
import six
272276
from google.cloud.runtimeconfig.variable import Variable
273277

274278
VARIABLE_1 = 'variable-one'
@@ -293,8 +297,8 @@ def test_list_variables_explicit(self):
293297
page_size=3,
294298
page_token=TOKEN,
295299
client=client)
296-
iterator.update_page()
297-
variables = list(iterator.page)
300+
page = six.next(iterator.pages)
301+
variables = list(page)
298302
token = iterator.next_page_token
299303

300304
self.assertEqual(len(variables), len(DATA['variables']))

0 commit comments

Comments
 (0)